Add ability to exclude logs #397
Open
+378
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsaamir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the ability to enable logs, but not the ability to EXCLUDE certain logs.
To enable logs you can simply do
LOG=TokenManagerand it'll only enable token logger logs and disable all other logs.But what if you wanted to include all logs, and exclude just some logs.
To enable this, we now have
LOG=-<loggerpattern>. This let's us selectively disable certain logs unless explicitly needed.I used it to disable azure/msal logs which are very noisy. If someone really wants to look at those logs, they may enable them via
LOG=*,azure/msalin their environment variables.In the near future, we should probably use an established package like winston or debug to do our logging.