Skip to content

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Oct 12, 2025

  • IAsyncDisposable implementation is very unnecessary here and is mostly dead code. It's technically binary breaking, but it's not expected that this API was used by any one. Our generated entry point disposes ITestApplication and not the concrete TestApplication. We dispose via the sync Dispose (the interface doesn't actually implement IAsyncDisposable). While binary breaking and should have been figured out before we ship 2.0.0, I think it only affects the case where users cast ITestApplication to TestApplication and calls DisposeAsync which is extremely unlikely.
  • CreateServerModeBuilderAsync is also mostly an unused public API. We don't use it in our generated entrypoint and I don't think there are any usages calling it. I went with obsoletion though instead of breaking. I would personally be fine taking a binary break here though. It's expected to affect literally zero users.

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/cleanup-testapp branch from b8115e9 to ac1825f Compare October 12, 2025 07:09
@Youssef1313 Youssef1313 merged commit 57c5191 into main Oct 13, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/cleanup-testapp branch October 13, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestApplication dispose implementation looks wrong

2 participants