Skip to content

Cleanup dead properties in TestMethod #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

Cleanup dead properties in TestMethod #6739

merged 1 commit into from
Oct 14, 2025

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Oct 14, 2025 •
edited
Loading

  • DeclaringAssemblyName was never read. It was only set. So cleaned it up.
  • After the removal of DeclaringAssemblyName, GetAssemblyPath method became unused. So removed it as well.
  • Then, isDeclaredInTestTypeAssembly parameter of GetTestFromMethod became unused. Cleaned it up as well.
  • Additionally, TestGroup property was never accessed. So removed it too.

@Youssef1313 Youssef1313 enabled auto-merge (squash) October 14, 2025 10:33
@Youssef1313 Youssef1313 merged commit 0628a5b into main Oct 14, 2025
9 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/cleanup-unused branch October 14, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engyebrahim engyebrahim engyebrahim approved these changes

@nohwnd nohwnd Awaiting requested review from nohwnd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Youssef1313 @engyebrahim