Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg script]WIP: ninja 1.12 (Reprise from #39260) #41980

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[vcpkg script]WIP: ninja 1.12 (Reprise from #39260) #41980

wants to merge 4 commits into from
+37 −19

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 6, 2024

No description provided.

@jimwang118 jimwang118 changed the title WIP: ninja 1.12 (Reprise from #39260) [vcpkg script]WIP: ninja 1.12 (Reprise from #39260) Nov 6, 2024
@jimwang118 jimwang118 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Nov 6, 2024
@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 8, 2024

android: Unrelated baseline regressions.

windows: qt5-webengine

  • legacy, needs python2
  • always was best-effort
  • vendored dependencies (chromium, skia) requiring gn requiring ninja.
  • ninja reaches 29348/33281.
  • Reason for error is unclear
jom: D:\b\qt5-webengine\x64-windows-dbg\src\core\Makefile.gn_run.Debug [run_ninja] Error 1
jom: D:\b\qt5-webengine\x64-windows-dbg\src\core\Makefile.gn_run [debug] Error 2
jom: D:\b\qt5-webengine\x64-windows-dbg\src\core\Makefile [sub-gn_run-pro-make_first] Error 2
jom: D:\b\qt5-webengine\x64-windows-dbg\src\Makefile [sub-core-make_first] Error 2
jom: D:\b\qt5-webengine\x64-windows-dbg\Makefile [sub-src-make_first] Error 2

... proposal: add legacy ninja as a per-port download.

@dg0yt dg0yt mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @jimwang118 @BillyONeal