Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Simplify cmake invokation in bootsrap.sh #41997

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[vcpkg] Simplify cmake invokation in bootsrap.sh #41997

wants to merge 1 commit into from
+4 −4

Commits on Nov 6, 2024

  1. [vcpkg] Simplify cmake invokation (microsoft#41996) 

    There's a [string escaping madness in bootstrap.sh's cmake invokation around line 217, making the script difficult to maintain.

I broke it before in PR microsoft#36828 which went into master undetected as it "worked over here" (tm) and isn't executed by the CI, but appearently it wouldn't work on arch linux' bash, resulting in PR microsoft#37047 .

microsoft/vcpkg-tool#1380 introduces a CMake Preset that can take over the cmake CLI variable setup.

This commit replaces the nested string composition by it's cmake-preset counterpart.
    @SchaichAlonso
    SchaichAlonso committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    780983b View commit details
    Browse the repository at this point in the history