Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libressl] Update to v4.0.0 #42145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[libressl] Update to v4.0.0 #42145

wants to merge 2 commits into from
+21 −56

Conversation

donny-dont
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@donny-dont
Copy link
Contributor Author

First time updating a port so happy to do whatever is needed to land this.

donny-dont
donny-dont commented Nov 14, 2024
View reviewed changes
Copy link
Contributor Author

@donny-dont donny-dont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding some notice on upstreaming attempts.

ports/libressl/patches/0002-Add-option-to-enable-spectre-mitigation-in-MSVC.patch Outdated Show resolved Hide resolved
ports/libressl/patches/0003-Disable-additional-MSVC-warnings.patch Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Nov 14, 2024
donny-dont
donny-dont commented Nov 14, 2024
View reviewed changes
Copy link
Contributor Author

@donny-dont donny-dont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will make the changes tomorrow. Thanks for the review!

ports/libressl/portfile.cmake Outdated Show resolved Hide resolved
ports/libressl/patches/0003-Disable-additional-MSVC-warnings.patch Outdated Show resolved Hide resolved
ports/libressl/patches/0002-Add-option-to-enable-spectre-mitigation-in-MSVC.patch Outdated Show resolved Hide resolved
@donny-dont
[libressl] Update to v4.0.0
f4c4e5d 
Removes `0002-suppress-msvc-warnings.patch`. The warnings were fixed and upstreamed into a downloaded patch. The spectre mitigation flags should be added in a triplet file.
@donny-dont
Copy link
Contributor Author

Okay @dg0yt and @LilyWangLL think this is ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donny-dont @dg0yt @LilyWangLL