Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libdmtx] Correct all errors encountered during of #44636 #44657

Merged
merged 3 commits into from
Apr 1, 2025
Merged

[libdmtx] Correct all errors encountered during of #44636 #44657

merged 3 commits into from
Apr 1, 2025

Conversation

sinfomicien
Copy link
Contributor

@sinfomicien sinfomicien commented Mar 27, 2025 •
edited
Loading

  • migrate to vcpkg_from_github
  • Remove unused OPTIONS in vcpkg_cmake_configure
  • Remove set(VCPKG_POLICY_ALLOW_DEBUG_INCLUDE enabled) from portfile and remove directory instead

Fix #44636

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@sinfomicien
Copy link
Contributor Author

sinfomicien commented Mar 27, 2025 •
edited
Loading

@dg0yt , this PR will complete the last one. Let me verify all CI tests are ok ,before requesting a new review.

@dg0yt
Copy link
Contributor

dg0yt commented Mar 27, 2025

You will probably have to remove ${CURRENT_PACKAGES_DIR}/debug/include.

dg0yt
dg0yt reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be ported to vcpkg_from_github.

@sinfomicien
Copy link
Contributor Author

This can probably be ported to vcpkg_from_github.

Let’s try it

@sinfomicien sinfomicien force-pushed the add-libdmtx-port branch 3 times, most recently from 366f78c to f485127 Compare March 27, 2025 18:24
@sinfomicien sinfomicien marked this pull request as ready for review March 27, 2025 18:32
@sinfomicien
Copy link
Contributor Author

sinfomicien commented Mar 27, 2025 •
edited
Loading

Ok @dg0yt , sorry for the mess about my last PR and the beginning of this one. I’m ready for review now. Let me just modify my commit message to say it’a about libdmtx port, and i force push it

@sinfomicien
[libdmtx] Correct all errors encountered during review of (microsoft#…
ddcaef0 
…44636)

- convert portfile to vcpkg_from_github
- Remove unused OPTIONS in vcpkg_cmake_configure
- Remove set(VCPKG_POLICY_ALLOW_DEBUG_INCLUDE enabled) from portfile and
  set a rule to remove ${CURRENT_PACKAGES_DIR}/debug/include instead
@WangWeiLin-MV WangWeiLin-MV self-assigned this Mar 28, 2025
@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Mar 28, 2025
@sinfomicien
Copy link
Contributor Author

Any chance to see this PR merged ? As it correct some mistake in my first PR, merged without review (#44636). Do i need to correct something else ?

@dg0yt
Copy link
Contributor

dg0yt commented Mar 31, 2025

Do you see why I asked for an immediate revert of the premature merge of #44636?
Ping @vicroms.

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Apr 1, 2025
@vicroms vicroms merged commit fbef4f4 into microsoft:master Apr 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@Thomas1664 Thomas1664 Thomas1664 left review comments

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sinfomicien @dg0yt @Thomas1664 @WangWeiLin-MV @vicroms