Skip to content

[libosdp] update to 3.2.5 - #52875

Merged
Billy O'Neal (BillyONeal) merged 3 commits into
microsoft:masterfrom
toge:libosdp-3.2.5
Aug 3, 2026
Merged

[libosdp] update to 3.2.5#52875
Billy O'Neal (BillyONeal) merged 3 commits into
microsoft:masterfrom
toge:libosdp-3.2.5

Conversation

@toge

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

https://github.com/osdp-dev/libosdp/releases/tag/v3.2.5

@vicroms Victor Romero (vicroms) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI found an issue when consuming this port in static Windows triplets.

Static Windows consumers cannot link libosdp. The installed public header always expands exported C APIs to __declspec(dllimport) unless BUILDING_API is defined, even for the static package (include/osdp_export.h). The static target only applies -DOSDP_STATIC_DEFINE while building the library (src/CMakeLists.txt), and that macro is not consumed by osdp_export.h or propagated to consumers. As a result, CMake, pkg-config, and direct static-link examples fail with unresolved __imp_osdp_* symbols on x64-windows-static.

We need to "bake in" a define in one of the library headers to fix this behavior.

@vicroms
Victor Romero (vicroms) marked this pull request as draft July 14, 2026 08:51
@toge
toge (toge) marked this pull request as ready for review August 2, 2026 11:36
SHA512 7a3fba87b294f91f01593f2abd07ff088248598db873996d29798cdf7e7733d298547a7b4305593a26ff77eaa972e8d513ca92f6477b7fabc5f773051676f8d0
HEAD_REF master
PATCHES
fix-export-macros.patch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT 5.6 points out that upstream has merged this fix, but I'm going to merge your change as is because it appears to be the same and predates upstream's change.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I just realized osdp-dev/libosdp@c8fce4e does not predate this change. Too late I guess :/

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@BillyONeal
Billy O'Neal (BillyONeal) merged commit 784f327 into microsoft:master Aug 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants