[libosdp] update to 3.2.5 - #52875
Conversation
Victor Romero (vicroms)
left a comment
There was a problem hiding this comment.
AI found an issue when consuming this port in static Windows triplets.
Static Windows consumers cannot link
libosdp. The installed public header always expands exported C APIs to__declspec(dllimport)unlessBUILDING_APIis defined, even for the static package (include/osdp_export.h). The static target only applies-DOSDP_STATIC_DEFINEwhile building the library (src/CMakeLists.txt), and that macro is not consumed byosdp_export.hor propagated to consumers. As a result, CMake, pkg-config, and direct static-link examples fail with unresolved__imp_osdp_*symbols onx64-windows-static.
We need to "bake in" a define in one of the library headers to fix this behavior.
| SHA512 7a3fba87b294f91f01593f2abd07ff088248598db873996d29798cdf7e7733d298547a7b4305593a26ff77eaa972e8d513ca92f6477b7fabc5f773051676f8d0 | ||
| HEAD_REF master | ||
| PATCHES | ||
| fix-export-macros.patch |
There was a problem hiding this comment.
GPT 5.6 points out that upstream has merged this fix, but I'm going to merge your change as is because it appears to be the same and predates upstream's change.
There was a problem hiding this comment.
Actually I just realized osdp-dev/libosdp@c8fce4e does not predate this change. Too late I guess :/
Billy O'Neal (BillyONeal)
left a comment
There was a problem hiding this comment.
Thanks for the update!
./vcpkg x-add-version --alland committing the result.https://github.com/osdp-dev/libosdp/releases/tag/v3.2.5