[ng-log] update to 0.8.3 - #52878
Closed
toge (toge) wants to merge 1 commit into
Closed
Conversation
Victor Romero (vicroms)
requested changes
Jul 14, 2026
Victor Romero (vicroms)
left a comment
Member
There was a problem hiding this comment.
Add the required public compile definitions to the generated pkg-config Cflags (or disable pkg-config until upstream metadata is complete).
AI found a pkg-conf usage issue:
The installed
libng-log.pcmetadata does not publish the compile definitions needed by public headers. A consumer using pkg-config receives only-I${includedir}, then<ng-log/logging.h>errors becauseNGLOG_USE_EXPORT/export macros are missing.
Victor Romero (vicroms)
marked this pull request as draft
July 14, 2026 08:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.https://github.com/ng-log/ng-log/releases/tag/v0.8.3