[libdicom] Remove unnecessary native compiler probe - #52922
Merged
Conversation
Native builds use the already-detected host compiler, while cross builds continue using the pre-generated dictionary.
Billy O'Neal (BillyONeal)
approved these changes
Jul 16, 2026
Billy O'Neal (BillyONeal)
left a comment
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
Seems plausible. Thanks!
Yury Bura (yurybura)
pushed a commit
to yurybura/vcpkg
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build issue in CI 20260708.1 run.
Upstream builds
dicom-dict-buildas a native executable, this causes a redundant compiler probe that fails withLNK1104. The patch makes it so that the host compiler is used for native builds and the pre-generated dictionary is used for cross builds.