[lfreist-hwinfo] Fix GCC build - #52933
Merged
Victor Romero (vicroms) merged 6 commits intoJul 18, 2026
Merged
Conversation
Contributor
Author
|
Added the "license" field to vcpkg.json, ran the 'vcpkg format-manifest ...' and 'vcpkg x-add-version --overwrite-version lfreist-hwinfo' commands |
Victor Romero (vicroms)
requested changes
Jul 17, 2026
Victor Romero (vicroms)
left a comment
Member
There was a problem hiding this comment.
Please fix the following:
- Modify the "license" field to declare
MIT AND BSD-3-Clauseand includepci.ids.hinvcpkg_install_copyright. - Set
-DHWINFO_GPU_OPENCL=OFFinvcpkg_cmake_configureto explicitly disable an optional OpenCL dependency.
Victor Romero (vicroms)
marked this pull request as draft
July 17, 2026 03:09
Uladzislau Marhunou (NotNachalas)
marked this pull request as ready for review
July 17, 2026 10:56
Uladzislau Marhunou (NotNachalas)
requested a review
from Victor Romero (vicroms)
July 17, 2026 10:56
Victor Romero (vicroms)
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.When trying to install the lfreist-hwinfo package for the x64-linux triplet with GCC-16, I got the following error: 'src/linux/disk.cpp:41:32: error: variable ‘std::istringstream iss’ has initializer but incomplete type'.
This PR fixes this build error by adding the required include file, .
Verified manually on the x64-windows, x64-linux triplets.