Skip to content

[lfreist-hwinfo] Fix GCC build - #52933

Merged
Victor Romero (vicroms) merged 6 commits into
microsoft:masterfrom
NotNachalas:lfreist-hwinfo-fix-gcc-build
Jul 18, 2026
Merged

[lfreist-hwinfo] Fix GCC build#52933
Victor Romero (vicroms) merged 6 commits into
microsoft:masterfrom
NotNachalas:lfreist-hwinfo-fix-gcc-build

Conversation

@NotNachalas

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

When trying to install the lfreist-hwinfo package for the x64-linux triplet with GCC-16, I got the following error: 'src/linux/disk.cpp:41:32: error: variable ‘std::istringstream iss’ has initializer but incomplete type'.
This PR fixes this build error by adding the required include file, .

Verified manually on the x64-windows, x64-linux triplets.

@NotNachalas

Copy link
Copy Markdown
Contributor Author

Added the "license" field to vcpkg.json, ran the 'vcpkg format-manifest ...' and 'vcpkg x-add-version --overwrite-version lfreist-hwinfo' commands

@vicroms Victor Romero (vicroms) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the following:

  • Modify the "license" field to declare MIT AND BSD-3-Clause and include pci.ids.h in vcpkg_install_copyright.
  • Set -DHWINFO_GPU_OPENCL=OFF in vcpkg_cmake_configure to explicitly disable an optional OpenCL dependency.

@vicroms
Victor Romero (vicroms) marked this pull request as draft July 17, 2026 03:09
@vicroms
Victor Romero (vicroms) merged commit 0c6775e into microsoft:master Jul 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants