Skip to content

[gstreamer,gst-rtsp-server] Update to 1.28.6 - #53324

Open
Andrew Tribick (ajtribick) wants to merge 2 commits into
microsoft:masterfrom
ajtribick:gstreamer-1.28.6
Open

[gstreamer,gst-rtsp-server] Update to 1.28.6#53324
Andrew Tribick (ajtribick) wants to merge 2 commits into
microsoft:masterfrom
ajtribick:gstreamer-1.28.6

Conversation

@ajtribick

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Release notes https://gstreamer.freedesktop.org/releases/1.28/#1.28.6 - includes fixes for compilation with FFmpeg 9.0

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT 5.6 Sol reports:

  • License metadata / installed notices remain incomplete or inconsistent for both ports. ports/gstreamer/vcpkg.json declares LGPL-2.0-only, while representative public headers such as gst.h carry a “version 2 or later” grant; ports/gst-rtsp-server/vcpkg.json declares LGPL-2.1-only, while representative public headers such as rtsp-server.h also carry a “version 2 or later” grant. That mismatch appears to pre-date this update, but the manifest license fields and installed copyright material still do not fully reflect the published grants (vcpkg manifest license docs).

would you consider merging ajtribick#5 ?

@ajtribick

Copy link
Copy Markdown
Contributor Author

Upstream repository LICENSE file indicates LGPL-2.1-or-later, so I will use that instead. Some of the features might require (A)GPL, but as far as I can see the vcpkg.json format doesn't support additional licenses at the feature level?

@BillyONeal

Copy link
Copy Markdown
Member

I think the ocean-boiling magic 8-ball got it wrong here, the LICENSE file at the root of the gstreamer repository indicates LGPL-2.1-or-later.
[...]
Upstream repository LICENSE file indicates LGPL-2.1-or-later

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/2d3e05cbdad68e47d645f548899b432dc9fb4473/subprojects/gstreamer/COPYING does not say the "-or-later" part which is why we're stuck digging through headers to confirm what is really meant if they don't clarify. I agree with you that it needs to be 2.1-or-later given the top level license file; I wish they would fix their declarations to be consistent though.

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sold, thank you!

@BillyONeal

Copy link
Copy Markdown
Member

the vcpkg.json format doesn't support additional licenses at the feature level?

It does allow that. For example:

"features": {
"tool": {
"description": "Build gsasl tool",
"license": "GPL-3.0-or-later"
}
}

(Leaving this "approve" because I would merge as is but not merging yet in case you want to make further changes given this example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants