Skip to content

Commit 114b3e3

Browse files
authored
Vscode-mssql bugs fixes for table (#17225)
* fixed wrong names for aria label * partially fixed tab order * removed tabindex="-1" * fixed tab indexes
1 parent 38df1e2 commit 114b3e3

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/views/htmlcontent/src/js/components/app.component.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -46,19 +46,19 @@ const template = `
4646
(click)="toggleResultsPane()"
4747
(keydown)="handleResultsKeydown($event)"
4848
[attr.aria-label]="Constants.resultPaneLabel"
49-
[attr.aria-expanded]="!resultActive">
49+
[attr.aria-expanded]="resultActive">
5050
<span> {{Constants.resultPaneLabel}} </span>
5151
<span class="shortCut"> {{resultShortcut}} </span>
5252
</div>
53-
<div id="results" tabIndex="0" *ngIf="renderedDataSets.length > 0" class="results vertBox scrollable"
53+
<div id="results" *ngIf="renderedDataSets.length > 0" class="results vertBox scrollable"
5454
(onScroll)="onScroll($event)"
5555
[scrollEnabled]="scrollEnabled"
5656
[class.hidden]="!resultActive">
5757
<div class="boxRow content horzBox slickgrid" *ngFor="let dataSet of renderedDataSets; let i = index"
5858
[style.max-height]="renderedDataSets.length > 1 ? dataSet.maxHeight + 'px' : 'inherit'"
5959
[style.min-height]="renderedDataSets.length > 1 ? dataSet.minHeight + 'px' : 'inherit'"
6060
[style.font-size]="resultsFontSize + 'px'">
61-
<slick-grid tabindex="0" #slickgrid id="slickgrid_{{i}}" [columnDefinitions]="dataSet.columnDefinitions"
61+
<slick-grid #slickgrid id="slickgrid_{{i}}" [columnDefinitions]="dataSet.columnDefinitions"
6262
[ngClass]="i === activeGrid ? 'active' : ''"
6363
[dataRows]="dataSet.dataRows"
6464
(contextMenu)="openContextMenu($event, dataSet.batchId, dataSet.resultId, i)"
@@ -85,10 +85,10 @@ const template = `
8585
</div>
8686
<context-menu #contextmenu (clickEvent)="handleContextClick($event)"></context-menu>
8787
<msg-context-menu #messagescontextmenu (clickEvent)="handleMessagesContextClick($event)"></msg-context-menu>
88-
<div id="messagepane" role="button" tabIndex="1" class="boxRow header collapsible"
88+
<div id="messagepane" role="button" tabIndex="0" class="boxRow header collapsible"
8989
[class.collapsed]="!messageActive"
9090
[attr.aria-label]="Constants.messagePaneLabel"
91-
[attr.aria-expanded]="!messageActive"
91+
[attr.aria-expanded]="messageActive"
9292
(click)="toggleMessagesPane()"
9393
(keydown)="handleMessagesKeydown($event)"
9494
style="position: relative">

0 commit comments

Comments
 (0)