Vscode-mssql bugs fixes for table #17225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanrenmsft
reviewed
Jan 28, 2022
|
please add description on how will the changes fix the issues. it is not obvious for me. |
alanrenmsft
reviewed
Feb 4, 2022
alanrenmsft
reviewed
Feb 4, 2022
alanrenmsft
reviewed
Feb 4, 2022
alanrenmsft
reviewed
Feb 4, 2022
alanrenmsft
reviewed
Feb 4, 2022
alanrenmsft
approved these changes
Feb 4, 2022
|
@smartguest I assume you have tested the changes I proposed. right? just want to make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17198
also
Fixes #17209
The changes here that I made are:
Changing the aria-expanded label of the results/messages header to properly reflect the current state of the collapsed/expanded dropdown. (Previously the state announced by the screen reader was opposite), instead of !resultActive/!messageActive, its now simply resultActive/messageActive
The slickgrid is no longer keyboard focusable