-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sort button to column header #18561
Conversation
PR Changes
|
Marking as draft because I still need to sort out some multi-column sort scenarios, and will continue work after ask mode. |
So the filter pop-up doesn't have sorting buttons any more, right? |
Chatted with Chris, there's still some work need to be done when sorting happens with filters applied.
|
it looks good @cssuh, thanks! |
What happens when you sort col1 then sort col2? Does col1 gets auto reset? |
Does the latest revision fix all these senarios? |
yes, that's correct |
yes it does :) |
Adding a sort button to each column header and removing it from the filter menu:

Behavior:

(also replaced old sort indicator assets)