Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sort button to column header #18561

Merged
merged 15 commits into from
Mar 10, 2025
Merged

Add a sort button to column header #18561

merged 15 commits into from
Mar 10, 2025

Conversation

cssuh
Copy link
Member

@cssuh cssuh commented Jan 17, 2025

Adding a sort button to each column header and removing it from the filter menu:
Screenshot 2025-01-17 at 7 38 59 AM

 Behavior:
sortResetState

(also replaced old sort indicator assets)

Copy link

github-actions bot commented Jan 17, 2025

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 51.06% 51.20% $${\color{lightgreen} .14\% }$$
VSIX Size 12987 KB 12987 KB $${\color{lightgreen} 0 KB \space (0\%) }$$
Webview Bundle Size 3188 KB 3196 KB $${\color{lightgreen} 8 KB \space (0\%) }$$

@cssuh cssuh marked this pull request as draft January 17, 2025 22:48
@cssuh
Copy link
Member Author

cssuh commented Jan 21, 2025

Marking as draft because I still need to sort out some multi-column sort scenarios, and will continue work after ask mode.

@cssuh cssuh marked this pull request as ready for review March 5, 2025 15:41
@caohai
Copy link
Member

caohai commented Mar 6, 2025

So the filter pop-up doesn't have sorting buttons any more, right?

@caohai
Copy link
Member

caohai commented Mar 6, 2025

Chatted with Chris, there's still some work need to be done when sorting happens with filters applied.
Example cases:

sort -> filter(same and/or different col) -> reset sort
filter(same and/or different col) -> sort -> reset sort

@croblesm
Copy link
Contributor

croblesm commented Mar 6, 2025

it looks good @cssuh, thanks!

@caohai
Copy link
Member

caohai commented Mar 10, 2025

What happens when you sort col1 then sort col2? Does col1 gets auto reset?

@caohai
Copy link
Member

caohai commented Mar 10, 2025

Chatted with Chris, there's still some work need to be done when sorting happens with filters applied. Example cases:

sort -> filter(same and/or different col) -> reset sort
filter(same and/or different col) -> sort -> reset sort

Does the latest revision fix all these senarios?

@cssuh
Copy link
Member Author

cssuh commented Mar 10, 2025

What happens when you sort col1 then sort col2? Does col1 gets auto reset?

yes, that's correct

@cssuh
Copy link
Member Author

cssuh commented Mar 10, 2025

Chatted with Chris, there's still some work need to be done when sorting happens with filters applied. Example cases:

sort -> filter(same and/or different col) -> reset sort
filter(same and/or different col) -> sort -> reset sort

Does the latest revision fix all these senarios?

yes it does :)

@cssuh cssuh merged commit e77bb30 into main Mar 10, 2025
6 checks passed
@cssuh cssuh deleted the chsuh/sortButton branch March 10, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants