-
Notifications
You must be signed in to change notification settings - Fork 543
Connections & Connection Groups can now be defined at both the User and Workspace level #19961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d2477b3
to
b5fa276
Compare
I'd like to take a different approach, and am interested in your feedback. What if, instead, the root ID is hardcoded as There'd no longer be an explicit entry needed for the root in the JSON, and both workspace and user config entries could reference What do you think? |
@Benjin I definitely like the flexibility that could offer, I'll give it a go. I think for that approach there will need to be some indicators in in the connections UI (visual/text based) distinguishing workspace connections from user ones. Or potentially splitting the connections window in half in some respect to create an even more clear separation, though I think there's more flexibility and less modifications necessary with the former. |
b5fa276
to
124667a
Compare
@Benjin after some experimenting, I think I've decided on a hybrid approach of mine and yours. We can switch to a hard coded root for the purposes you described, but I'd still like to keep workspace and user connections in separate predefined groups. Allowing users to mix and match user/workspace connections and groups just seems a bit disorganized and could create a lot of unexpected and problematic behavior that's more trouble than it's worth accounting for. |
124667a
to
e22b652
Compare
ae2f9b6
to
96d71d5
Compare
96d71d5
to
00c3977
Compare
@Benjin I think creating a hard coded root is out of scope for this pull request, though it shouldn't be very difficult with this new approach. That being said, all of my intended functionality is now implemented. While many tests still don't pass (and I need to rework some code to use constants and locConstants), I'd appreciate a review just to make sure I'm on the right track here and it's worth continuing on to fixing the unit tests. |
916a8de
to
bd9aea1
Compare
bd9aea1
to
11e2cfd
Compare
ef7cc94
to
6eaaa9c
Compare
cbbb8b7
to
ac27b81
Compare
…oot connections. Migration logic implemented for migrating root coonections to user connections
…ce Until it's needed
ac27b81
to
bf25724
Compare
@aasimkhan30 @Benjin I've been consistently rebasing this branch on your changes, I've started doing releases with this branch for easier testing. Let me know any thoughts/what might need to be done beyond reworking tests to get this pull request merged. |
Hey @samgusick, I think we're likely going to end up making some further changes in this space internally, so while we're still looking to resolve this issue, I'm not sure if we'll end up using this specific PR. Because the final design or implementation details may end up being different from how this PR works, I worry it could cause more confusion to other users if you're posting your own releases. Also, it's important to note that we can only support the official, first-party releases that we post on the official page. Though I also want to reiterate that we do appreciate the passion and contributions, even in instances where we don't merge the PRs in. :) |
Pull Request Template – vscode-mssql
Description
This pull request fixes #19780
For those Interested in testing this branch, I've started doing releases here!
Problem:
Connections and connection groups cannot be defined at the workspace level (at least not in a user friendly, safe way). Having connections specific to workspaces can help with organization, especially when there are many connections across different projects and only a handful need to be used in each workspace.
What this does:
WARNING: these changes fundamentally alter the extensions approach to connections and connection groups within the existing framework. Many tests will need to be rewritten, and I'll need to do more work to make sure ones that should remain still pass. Additionally, user and workspace settings will be modified, so be mindful when testing with this branch.
My TO DO:
Code Changes Checklist
npm run test
)Reviewers: Please read our reviewer guidelines