Converting TypeMoq tests to sinon

README.md

@@ -208,7 +208,7 @@ The following Visual Studio Code settings are available for the mssql extension.
 // Status bar
 {
   "mssql.statusBar.connectionInfoMaxLength": -1,
-  "mssql.statusBar.enableConnectionColor": true,
+  "mssql.enableConnectionColor": true,
 }
 ```
 

test/unit/adapter.test.ts

@@ -3,16 +3,22 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import * as vscode from "vscode";
-import * as TypeMoq from "typemoq";
+import { expect } from "chai";
+import * as chai from "chai";
+import sinonChai from "sinon-chai";
+import * as sinon from "sinon";
 import CodeAdapter from "../../src/prompts/adapter";
 import VscodeWrapper from "../../src/controllers/vscodeWrapper";
 import { IQuestion } from "../../src/prompts/question";
+import { stubVscodeWrapper } from "./utils";
+
+chai.use(sinonChai);
 
 suite("Code Adapter Tests", () => {
+    let sandbox: sinon.SinonSandbox;
     let adapter: CodeAdapter;
-    let outputChannel: TypeMoq.IMock<vscode.OutputChannel>;
-    let vscodeWrapper: TypeMoq.IMock<VscodeWrapper>;
+    let mockVscodeWrapper: sinon.SinonStubbedInstance<VscodeWrapper>;
+
     const testMessage = {
         message: "test_message",
         code: 123,
@@ -27,53 +33,58 @@ suite("Code Adapter Tests", () => {
     };
 
     setup(() => {
-        vscodeWrapper = TypeMoq.Mock.ofType(VscodeWrapper, TypeMoq.MockBehavior.Loose);
-        outputChannel = TypeMoq.Mock.ofType<vscode.OutputChannel>();
-        outputChannel.setup((o) => o.appendLine(TypeMoq.It.isAnyString()));
-        outputChannel.setup((o) => o.clear());
-        outputChannel.setup((o) => o.show());
-        vscodeWrapper.setup((v) => v.outputChannel).returns(() => outputChannel.object);
-        vscodeWrapper.setup((v) => v.showErrorMessage(TypeMoq.It.isAnyString()));
-        adapter = new CodeAdapter(vscodeWrapper.object);
+        sandbox = sinon.createSandbox();
+        mockVscodeWrapper = stubVscodeWrapper(sandbox);
+
+        mockVscodeWrapper.showErrorMessage.resolves(undefined);
+
+        adapter = new CodeAdapter(mockVscodeWrapper);
+    });
+
+    teardown(() => {
+        sandbox.restore();
     });
 
     test("logError should append message to the channel", () => {
         adapter.logError(testMessage);
-        outputChannel.verify((o) => o.appendLine(TypeMoq.It.isAnyString()), TypeMoq.Times.once());
+        expect(mockVscodeWrapper.outputChannel.appendLine).to.have.been.calledOnce;
     });
 
     test("log should format message and append to the channel", () => {
         adapter.log(testMessage);
-        outputChannel.verify((o) => o.appendLine(TypeMoq.It.isAnyString()), TypeMoq.Times.once());
+        expect(mockVscodeWrapper.outputChannel.appendLine).to.have.been.calledOnce;
     });
 
     test("clearLog should clear from output channel", () => {
         adapter.clearLog();
-        outputChannel.verify((o) => o.clear(), TypeMoq.Times.once());
+        expect(mockVscodeWrapper.outputChannel.clear).to.have.been.calledOnce;
     });
 
     test("showLog should show the output channel", () => {
         adapter.showLog();
-        outputChannel.verify((o) => o.show(), TypeMoq.Times.once());
+        expect(mockVscodeWrapper.outputChannel.show).to.have.been.calledOnce;
     });
 
-    test("promptSingle and promptCallback should call prompt", () => {
-        void adapter.promptSingle(testQuestion);
+    test("promptSingle and promptCallback should call prompt", async () => {
+        await adapter.promptSingle(testQuestion);
         adapter.promptCallback([testQuestion], () => true);
         // Error case
-        void adapter.prompt([{ type: "test", message: "test", name: "test" }]);
+        await adapter.prompt([{ type: "test", message: "test", name: "test" }]);
     });
 
-    test("prompting a checkbox question should call fixQuestion", () => {
-        let formattedQuestion: IQuestion = {
+    test("prompting a checkbox question should call fixQuestion", async () => {
+        const formattedQuestion: IQuestion = {
             type: "checkbox",
             message: "test",
             name: "test_checkbox",
             choices: [{ name: "test_choice", value: "test_choice" }],
         };
-        void adapter.promptSingle(formattedQuestion);
-        let question: any = Object.assign({}, formattedQuestion);
-        question.choices[0] = "test";
-        void adapter.promptSingle(question);
+        await adapter.promptSingle(formattedQuestion);
+        const question: IQuestion = {
+            ...formattedQuestion,
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            choices: ["test" as any], // Intentionally wrong type to trigger fixQuestion
+        };
+        await adapter.promptSingle(question);
     });
 });