Skip to content

Conversation

aasimkhan30
Copy link
Contributor

@aasimkhan30 aasimkhan30 commented Oct 3, 2025

Description

This PR

  1. Upgrades the column menu popup to use fluent UI.
  2. Moves sort into column menu to match ADS.
  3. Adds Alt + Down arrow to show column menu.
  4. Adds esc on filter popup to go back to grid.
  5. Separate search and select all checkbox.
  6. Improve layout
image

Old UI for reference:
image

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@aasimkhan30 aasimkhan30 changed the title Fixes filter Fixes grid filter menu Oct 3, 2025
Copy link

github-actions bot commented Oct 3, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 56.26% 56.26% ⚪ 0.00%
VSIX Size 4850 KB 4854 KB ⚪ 4 KB ( 0% )
Webview Bundle Size 4008 KB 4012 KB ⚪ 4 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.40%. Comparing base (1082aad) to head (dae8cd9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #20278   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files         198      198           
  Lines       17588    17588           
  Branches     1168     1168           
=======================================
  Hits         9568     9568           
  Misses       8020     8020           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kburtram
kburtram previously approved these changes Oct 3, 2025
@aasimkhan30 aasimkhan30 merged commit c6866eb into main Oct 8, 2025
2 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/18839 branch October 8, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants