-
Notifications
You must be signed in to change notification settings - Fork 542
Moving grid summary generation and copying to sts for perf #20285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20285 +/- ##
==========================================
- Coverage 54.40% 53.70% -0.70%
==========================================
Files 198 198
Lines 17588 17267 -321
Branches 1168 1156 -12
==========================================
- Hits 9568 9273 -295
+ Misses 8020 7994 -26
🚀 New features to boost your workflow:
|
lewis-sanchez
approved these changes
Oct 10, 2025
This was referenced Oct 16, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Key Changes
STS PR that moves everything to the backend: microsoft/sqltoolsservice#2520
Frontend Summary
Screen.Recording.2025-10-06.at.11.08.44.PM.mov
Backend Summary
Screen.Recording.2025-10-06.at.11.05.25.PM.mov
Copy Operation
Not much has changed on the copy side except for adding a loading bar:
Screen.Recording.2025-10-09.at.3.11.16.PM.mov
Code Changes Checklist
npm run test
)Reviewers: Please read our reviewer guidelines