Skip to content

Conversation

aasimkhan30
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

This in response to #20261 (comment)

The user needs a connection string in order to run some sqlpackage command through their extension.

This API checks if the user has granted permissions to share connection with the external extension and then shares the connection string for the connection id.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link

github-actions bot commented Oct 14, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 55.72% 55.53% ⚪ 0.00%
VSIX Size 4857 KB 4852 KB ⚪ -5 KB ( 0% )
Webview Bundle Size 4008 KB 4008 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.65%. Comparing base (2c77db9) to head (cae9366).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/connectionSharing/connectionSharingService.ts 0.00% 14 Missing ⚠️
src/extension.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20300      +/-   ##
==========================================
- Coverage   53.70%   53.65%   -0.05%     
==========================================
  Files         198      198              
  Lines       17267    17283      +16     
  Branches     1156     1157       +1     
==========================================
  Hits         9273     9273              
- Misses       7994     8010      +16     
Files with missing lines Coverage Δ
src/extension.ts 21.17% <0.00%> (-0.52%) ⬇️
src/connectionSharing/connectionSharingService.ts 7.69% <0.00%> (-0.47%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasimkhan30 aasimkhan30 merged commit 8492c10 into main Oct 18, 2025
3 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/connSharingString branch October 18, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants