Skip to content

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Oct 15, 2025

Pull Request Template – vscode-mssql

Description

  • Adds a button to clear the token cache if a multiple_matching_tokens error is detected.
  • Adds the ability to add action buttons and specify intent (error/warning/success/info) for messages.

Fixes #19733

image

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@Benjin Benjin linked an issue Oct 15, 2025 that may be closed by this pull request
13 tasks
@Benjin Benjin changed the title Dev/benjin/promptable messages Adding actionable message banners and clear token cache button Oct 15, 2025
Copy link

github-actions bot commented Oct 15, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 55.79% 56.06% ⚪ 0.00%
VSIX Size 4856 KB 4862 KB ⚪ 6 KB ( 0% )
Webview Bundle Size 4008 KB 4024 KB ⚪ 16 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.14%. Comparing base (d14ec84) to head (1bfa56a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...nectionconfig/connectionDialogWebviewController.ts 55.88% 15 Missing ⚠️
src/connectionconfig/azureHelpers.ts 0.00% 3 Missing ⚠️
src/controllers/connectionManager.ts 0.00% 2 Missing ⚠️
src/controllers/mainController.ts 0.00% 2 Missing ⚠️
src/languageservice/serviceclient.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20305      +/-   ##
==========================================
+ Coverage   53.83%   54.14%   +0.31%     
==========================================
  Files         198      198              
  Lines       17318    17329      +11     
  Branches     1155     1150       -5     
==========================================
+ Hits         9323     9383      +60     
+ Misses       7995     7946      -49     
Files with missing lines Coverage Δ
src/azure/msal/msalAzureController.ts 46.40% <100.00%> (ø)
src/constants/locConstants.ts 80.81% <100.00%> (+0.02%) ⬆️
src/sharedInterfaces/connectionDialog.ts 95.45% <ø> (-0.11%) ⬇️
src/languageservice/serviceclient.ts 27.23% <0.00%> (ø)
src/controllers/connectionManager.ts 43.21% <0.00%> (+0.55%) ⬆️
src/controllers/mainController.ts 16.28% <0.00%> (+0.83%) ⬆️
src/connectionconfig/azureHelpers.ts 56.54% <0.00%> (ø)
...nectionconfig/connectionDialogWebviewController.ts 46.67% <55.88%> (+6.22%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjin Benjin merged commit 6731798 into main Oct 16, 2025
3 checks passed
@Benjin Benjin deleted the dev/benjin/promptableMessages branch October 16, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Auto-prompt to clear Entra token cache

3 participants