-
Notifications
You must be signed in to change notification settings - Fork 543
Adding fixes for get rows out of bounds. #20307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+71
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-mssql into aasim/fix/20283
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20307 +/- ##
=======================================
Coverage 53.83% 53.83%
=======================================
Files 198 198
Lines 17318 17318
Branches 1155 1155
=======================================
Hits 9323 9323
Misses 7995 7995 🚀 New features to boost your workflow:
|
Benjin
reviewed
Oct 17, 2025
Benjin
reviewed
Oct 17, 2025
Benjin
previously approved these changes
Oct 17, 2025
Benjin
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
While I was not able to repo this issue, I am adding more guardrails around the getRows code so it doesn't lead to negative row fetches.
This also adds debouncing when scrolling through tables so that we don't spam sts with too many requests and also adding checks so that cell values don't keep fluctuating as we try to update from state results.
Fixes: #20283
Before:
Fixed:
Code Changes Checklist
npm run test
)Reviewers: Please read our reviewer guidelines