Skip to content

Conversation

aasimkhan30
Copy link
Contributor

@aasimkhan30 aasimkhan30 commented Oct 15, 2025

Pull Request Template – vscode-mssql

Description

While I was not able to repo this issue, I am adding more guardrails around the getRows code so it doesn't lead to negative row fetches.

This also adds debouncing when scrolling through tables so that we don't spam sts with too many requests and also adding checks so that cell values don't keep fluctuating as we try to update from state results.

Fixes: #20283

Before:

Code_mWBpYpLpnj

Fixed:

Code_94vWT6pDYj

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link

github-actions bot commented Oct 15, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 55.93% 55.72% ⚪ 0.00%
VSIX Size 4859 KB 4857 KB ⚪ -2 KB ( 0% )
Webview Bundle Size 4008 KB 4012 KB ⚪ 4 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.83%. Comparing base (f0b8470) to head (4881593).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #20307   +/-   ##
=======================================
  Coverage   53.83%   53.83%           
=======================================
  Files         198      198           
  Lines       17318    17318           
  Branches     1155     1155           
=======================================
  Hits         9323     9323           
  Misses       7995     7995           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Benjin
Benjin previously approved these changes Oct 17, 2025
@aasimkhan30 aasimkhan30 merged commit 68ef359 into main Oct 20, 2025
3 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/20283 branch October 20, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Offset and Length Out of Bounds

3 participants