Skip to content

Conversation

laurenastrid1
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

Fixes #20198

Previously, the code validated both capacity and workspace permissions to determine which workspaces were available for database provisioning. However, only workspace permissions are actually required, as outlined in the documentation below.
Doc: https://learn.microsoft.com/en-us/rest/api/fabric/sqldatabase/items/create-sql-database?tabs=HTTP

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 55.79% 55.71% ⚪ 0.00%
VSIX Size 4856 KB 4856 KB ⚪ 0 KB ( 0% )
Webview Bundle Size 4008 KB 4008 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.83%. Comparing base (4f08005) to head (d94d5f5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/deployment/fabricProvisioningHelpers.ts 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20311      +/-   ##
==========================================
- Coverage   53.83%   53.83%   -0.01%     
==========================================
  Files         198      198              
  Lines       17309    17279      -30     
  Branches     1153     1151       -2     
==========================================
- Hits         9319     9302      -17     
+ Misses       7990     7977      -13     
Files with missing lines Coverage Δ
src/constants/locConstants.ts 80.74% <ø> (-0.03%) ⬇️
src/sharedInterfaces/fabricProvisioning.ts 91.30% <ø> (-0.37%) ⬇️
src/deployment/fabricProvisioningHelpers.ts 42.80% <0.00%> (-0.99%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Some workspaces are incorrectly listed as insufficient capacity

3 participants