Skip to content

Conversation

@aasimkhan30
Copy link
Contributor

@aasimkhan30 aasimkhan30 commented Oct 20, 2025

Pull Request Template – vscode-mssql

Description

  1. Showing column menu shortcut
image
  1. Making command bar in results grid a toolbar so that we can navigate the buttons with arrow keys.
image
  1. Adding keyboard shortcuts to context menu
image

4.Adding shortcuts.

  1. Shift + Alt + 0 for sort
  2. Fix tab behavior in grid (tab moves to next element out of grid, where as shift tab moves to previous element before grid)
  3. Shift + space selects entire row.
  4. Shift + F10 opens context menu
  5. meta + space selects entire column
  6. meta + left arrow moves to first cell of the row.
  7. meta + right arrow moves to the last cell of the row.
  8. F3 Will show column menu. Fixes Users are not able to access Sort and Filter functionality present for column headers via keyboard:A11y_MSSQL for VSCode_Connection database_Adding New Query_Keyboard. #19821

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 56.55% 55.88% ⚪ 0.00%
VSIX Size 4867 KB 4861 KB ⚪ -6 KB ( 0% )
Webview Bundle Size 4016 KB 4020 KB ⚪ 4 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.91%. Comparing base (eee49dc) to head (33a9412).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #20327   +/-   ##
=======================================
  Coverage   53.91%   53.91%           
=======================================
  Files         198      198           
  Lines       17125    17125           
  Branches     1140     1140           
=======================================
  Hits         9233     9233           
  Misses       7892     7892           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjin
Copy link
Contributor

Benjin commented Oct 21, 2025

How'd you end up picking these shortcuts? IMO, we should generally avoid using meta shortcuts since those are typically intended for OS-level features that might conflict. Like:

meta + space: spotlight on macOS
meta + arrrow: window-snapping on Windows

I, for one, would find those particular overlaps to be pretty annoying if my VS Code window keeps moving around when I'm trying to move to specific columns, or spotlight keeps opening when I try to select a column.

@aasimkhan30 aasimkhan30 merged commit e882032 into main Oct 22, 2025
2 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/keyboardAccessibility branch October 22, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants