Conversation
| "mssql.shortcuts": { | ||
| "type": "object", | ||
| "description": "Shortcuts related to the results window", | ||
| "description": "%mssql.shortcut%", |
There was a problem hiding this comment.
mssql.shortcut [](start = 27, length = 14)
will fix this. should be %mssql.shortcuts% #Resolved
| this._service.addPostHandler(Interfaces.ContentType.ShowError, (req, res) => this.showErrorRequestHandler(req, res)); | ||
| // add http post handler for showing warning to user | ||
| this._service.addPostHandler(Interfaces.ContentType.ShowWarning, (req, res) => this.showWarningRequestHandler(req, res)); | ||
| this._service.addHandler(Interfaces.ContentType.LocalizedText, (req, res) => { |
There was a problem hiding this comment.
will add comment #Resolved
| @@ -0,0 +1,68 @@ | |||
| { | |||
| "extension.runQuery" : "Execute Query", | |||
There was a problem hiding this comment.
Is there an xliff file for these? And a process to build the localized package.nls files during build? #Resolved
| const self = this; | ||
| this.setupResizeBind(); | ||
|
|
||
| Constants.ConstantTypes.forEach(element => { |
There was a problem hiding this comment.
Please do a single call and return all constants. #Resolved
| this[key] = value; | ||
| }; | ||
|
|
||
| export enum ConstantType { |
There was a problem hiding this comment.
You can get rid of this once it's a map. thanks! #Resolved
…ting package.nls.json at build time
| const self = this; | ||
| this.setupResizeBind(); | ||
|
|
||
|
|
There was a problem hiding this comment.
Minor: remove this whitespace #Resolved
| export let msgCannotSaveMultipleSelections = 'Save results command cannot be used with multiple selections.'; | ||
|
|
||
| export let loadLocalizedConstant = (key: string, value: string) => { | ||
| this[key] = value; |
There was a problem hiding this comment.
Minor: maybe document what this does / how it works. It's kinda magic (but cool) #Resolved
| export const selectAll = 'Select all'; | ||
| export const copyLabel = 'Copy'; | ||
| export const copyWithHeadersLabel = 'Copy with Headers'; | ||
| export let maximizeLabel = 'Maximize'; |
There was a problem hiding this comment.
Please doc that all new strings added here must be added to the xliff. Otherwise people may miss this #Resolved
4 participants
Fixed Some UI text is not properly localized #855 and Context menu actions are not localized #783