Skip to content

Optimize pytest duplicate check from O(n) to O(1) using sets #25658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eleanorjboyd merged 3 commits into from
Dec 12, 2025
Merged

Optimize pytest duplicate check from O(n) to O(1) using sets #25658

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d7158c
Initial plan
Copilot Dec 12, 2025
eef1a43
Optimize pytest duplicate check from O(n) to O(1) by using set instea…
Copilot Dec 12, 2025
90f6a31
Merge branch 'main' into initial-spoonbill
eleanorjboyd Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python_files/vscode_pytest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def __init__(self, message):
ERRORS = []
IS_DISCOVERY = False
map_id_to_path = {}
collected_tests_so_far = []
collected_tests_so_far = set()
TEST_RUN_PIPE = os.getenv("TEST_RUN_PIPE")
SYMLINK_PATH = None
INCLUDE_BRANCHES = False
Expand Down Expand Up @@ -175,7 +175,7 @@ def pytest_exception_interact(node, call, report):
report_value = "failure"
node_id = get_absolute_test_id(node.nodeid, get_node_path(node))
if node_id not in collected_tests_so_far:
collected_tests_so_far.append(node_id)
collected_tests_so_far.add(node_id)
item_result = create_test_outcome(
node_id,
report_value,
Expand Down Expand Up @@ -300,7 +300,7 @@ def pytest_report_teststatus(report, config): # noqa: ARG001
# Calculate the absolute test id and use this as the ID moving forward.
absolute_node_id = get_absolute_test_id(report.nodeid, node_path)
if absolute_node_id not in collected_tests_so_far:
collected_tests_so_far.append(absolute_node_id)
collected_tests_so_far.add(absolute_node_id)
item_result = create_test_outcome(
absolute_node_id,
report_value,
Expand Down Expand Up @@ -334,7 +334,7 @@ def pytest_runtest_protocol(item, nextitem): # noqa: ARG001
report_value = "skipped"
cwd = pathlib.Path.cwd()
if absolute_node_id not in collected_tests_so_far:
collected_tests_so_far.append(absolute_node_id)
collected_tests_so_far.add(absolute_node_id)
item_result = create_test_outcome(
absolute_node_id,
report_value,
Expand Down