[email protected]

[Tyriar]

• Updates conpty Update conpty to 1.23.251008001 node-pty#811
• Adds Buffer support to API Support Buffer in write API node-pty#812

Part of #269213

[Tyriar]

@anthonykim1 this seems to be locking up the pty host somehow ☹️

[Copilot]

Pull Request Overview

This PR updates the node-pty dependency from version 1.1.0-beta35 to ^1.1.0-beta39 and removes a type casting workaround that is no longer necessary with the newer version.

Key changes:

• Upgraded node-pty to version ^1.1.0-beta39 in all package manifests
• Removed the as any type cast when writing binary data to the pty process, along with associated TODO and eslint-disable comments

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/vs/platform/terminal/node/terminalProcess.ts	Removed as any cast and related comments when writing Buffer to pty process, now that node-pty supports Buffer type natively
package.json	Updated node-pty dependency version to ^1.1.0-beta39
package-lock.json	Updated lock file with new node-pty version and integrity hash
remote/package.json	Updated node-pty dependency version to ^1.1.0-beta39 for remote package
remote/package-lock.json	Updated remote lock file with new node-pty version and integrity hash

Files not reviewed (1)

• remote/package-lock.json: Language not supported

[anthonykim1]

@Tyriar Are you still getting the odd behavior?

Things seem fine maybe except for ptyServiceInput undefined log when I pulled this locally:
https://github.com/user-attachments/assets/f23ca913-da82-4732-9a74-282c5bdf26ea

[Tyriar]

I think so, we need to manually test on Windows when we try updating.