Add configurable extension download timeout setting #274761

Copilot · 2025-11-03T14:16:52Z

Corporate proxies with security scanning can stall initial data transfer for 60+ seconds, causing extension installation failures with the hardcoded 10-second timeout.

Changes

Configuration (src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts)

Added extensions.requestTimeout setting (default: 60000ms, min: 0)
Scoped specifically to extension downloads from the Marketplace
Registered in extensions contribution following VS Code patterns
Tagged as using online services with APPLICATION scope

Extension Gallery Service (src/vs/platform/extensionManagement/common/extensionGalleryService.ts)

Replaced hardcoded REQUEST_TIME_OUT = 10_000 with DEFAULT_REQUEST_TIMEOUT = 60000 constant
Added getRequestTimeout() to read from extensions.requestTimeout configuration with fallback to default
Updated 4 HTTP request sites: metadata fetch, asset downloads (primary/fallback), control manifest fetch

Usage

{
  "extensions.requestTimeout": 90000  // 90 seconds
}

Set to 0 to disable timeout.

Addresses @chrmarti's feedback to increase default before adding configurability and @sandy081's feedback to scope the setting to extensions only rather than making it a general HTTP setting.

Original prompt

This section details on the original issue you should resolve

<issue_title>Add setting for electron request timeout, currently 10000ms, used when installing extensions</issue_title>
<issue_description>

I'd like to install VS Code extensions like Copilot and Python. The network path traverses a corporate proxy server that performs various scans etc. before it relinquishes any data. This process results in a 60+ second "stall" at the start of the download. VS Code always gives up after 10 seconds. A sample error is shown next:
2025-06-24 16:06:52.654 [error] [Window] Request timeout after 10000ms: Error: Request timeout after 10000ms
at Timeout.<anonymous> (file:///Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-utility/sharedProcess/sharedProcessMain.js:116:27676)
at listOnTimeout (node:internal/timers:588:17)
at process.processTimers (node:internal/timers:523:7)
2025-06-24 16:06:54.684 [trace] [Network] 
Please expose the 10000ms setting so it could be increased as needed. Thanks in advance for considering this.</issue_description>

Comments on the Issue (you are @copilot in this section)
@chrmarti @sandy081 Could this be a regression from https://github.com/microsoft/vscode/commit/8e2a65c89f7c69cf3be53c6c597d3bd5be07ead0? Can we increase this before adding another setting?

Fixes Add setting for electron request timeout, currently 10000ms, used when installing extensions #258236

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

sandy081 · 2025-11-03T14:34:07Z

@copilot

Add http.requestTimeout configuration setting with appropriate default

Do not make this general http setting, instead scope this only to extension requests. So name it accordingly. You can place this setting in extensions.contribution.ts - Check how the settings are registered here

- Add `http.requestTimeout` configuration with 60000ms default - Update extension gallery service to use configurable timeout - Remove hardcoded REQUEST_TIME_OUT constant - Allow users to customize timeout for slow corporate proxies Co-authored-by: sandy081 <[email protected]>

- Add DEFAULT_REQUEST_TIMEOUT constant (60000ms) - Use constant in getRequestTimeout() method instead of magic number - Improves maintainability and consistency Co-authored-by: sandy081 <[email protected]>

src/vs/platform/request/common/request.ts

- Move setting from http.requestTimeout to extensions.requestTimeout - Register setting in extensions.contribution.ts as requested - Update extensionGalleryService to use extensions.requestTimeout - Revert changes to request.ts (no longer general HTTP setting) Co-authored-by: sandy081 <[email protected]>

Copilot · 2025-11-03T15:15:21Z

@copilot

Add http.requestTimeout configuration setting with appropriate default
...

Done. Changed from http.requestTimeout to extensions.requestTimeout and registered the setting in extensions.contribution.ts as you suggested. The setting is now scoped specifically to extension downloads rather than being a general HTTP setting. (commit f4319b2)

Copilot

Pull Request Overview

This PR adds a configurable timeout for HTTP requests made to the Extensions Marketplace. Previously, requests used a hardcoded timeout of 10 seconds; now users can configure this timeout via the extensions.requestTimeout setting, with a new default of 60 seconds.

Introduces extensions.requestTimeout configuration setting with a default of 60,000ms
Replaces hardcoded REQUEST_TIME_OUT constant (10,000ms) with dynamic getRequestTimeout() method
Validates configured timeout values ensuring they are numbers and non-negative

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/vs/platform/extensionManagement/common/extensionManagement.ts	Exports new configuration key constant `ExtensionRequestsTimeoutConfigKey`
src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts	Registers the timeout configuration setting in the workbench with validation and metadata
src/vs/platform/extensionManagement/common/extensionGalleryService.ts	Implements `getRequestTimeout()` method and replaces all hardcoded timeout values with dynamic configuration

Copilot · 2025-11-05T11:08:03Z

src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts

 			},
+			[ExtensionRequestsTimeoutConfigKey]: {
+				type: 'number',
+				description: localize('extensionsRequestTimeout', "Controls the timeout in milliseconds for HTTP requests made when fetching extensions from the Marketplace"),


Configuration descriptions should end with a period for consistency with other settings in this file (see lines 260, 265, 270, 277, 283, 302).

Suggested change

description: localize('extensionsRequestTimeout', "Controls the timeout in milliseconds for HTTP requests made when fetching extensions from the Marketplace"),

description: localize('extensionsRequestTimeout', "Controls the timeout in milliseconds for HTTP requests made when fetching extensions from the Marketplace."),

I guess y'all ignored this bot comment :)

Copilot · 2025-11-05T11:08:04Z

src/vs/platform/extensionManagement/common/extensionGalleryService.ts


+	private getRequestTimeout(): number {
+		const configuredTimeout = this.configurationService.getValue<number>(ExtensionRequestsTimeoutConfigKey);
+		return isNumber(configuredTimeout) && configuredTimeout >= 0 ? configuredTimeout : 60_000;


The fallback value 60_000 is a magic number duplicated from line 308 in extensions.contribution.ts. Consider extracting this as a named constant (e.g., DEFAULT_REQUEST_TIMEOUT) to avoid duplication and make maintenance easier if the default ever needs to change.

Initial plan

f88cfee

Copilot AI assigned Copilot and sandy081 Nov 3, 2025

Copilot started work on behalf of sandy081 November 3, 2025 14:17 View session

Copilot AI and others added 2 commits November 3, 2025 14:41

Address code review: Add constant for default timeout value

c28dfc0

- Add DEFAULT_REQUEST_TIMEOUT constant (60000ms) - Use constant in getRequestTimeout() method instead of magic number - Improves maintainability and consistency Co-authored-by: sandy081 <[email protected]>

Copilot AI changed the title ~~[WIP] Add setting for electron request timeout, currently 10000ms, used when installing extensions~~ Add configurable HTTP request timeout for extension downloads Nov 3, 2025

Copilot AI requested a review from sandy081 November 3, 2025 14:58

Copilot finished work on behalf of sandy081 November 3, 2025 14:58

Copilot started work on behalf of sandy081 November 3, 2025 14:58 View session

sandy081 reviewed Nov 3, 2025

View reviewed changes

src/vs/platform/request/common/request.ts Outdated Show resolved Hide resolved

Copilot AI changed the title ~~Add configurable HTTP request timeout for extension downloads~~ Add configurable extension download timeout setting Nov 3, 2025

Copilot AI requested a review from sandy081 November 3, 2025 15:19

Copilot finished work on behalf of sandy081 November 3, 2025 15:19

Copilot started work on behalf of sandy081 November 3, 2025 15:19 View session

Copilot finished work on behalf of sandy081 November 3, 2025 15:33

review

27c808d

sandy081 approved these changes Nov 5, 2025

View reviewed changes

sandy081 marked this pull request as ready for review November 5, 2025 10:57

Copilot AI review requested due to automatic review settings November 5, 2025 10:57

sandy081 enabled auto-merge (squash) November 5, 2025 10:58

sandy081 added this to the October 2025 milestone Nov 5, 2025

lszomoru approved these changes Nov 5, 2025

View reviewed changes

Copilot AI reviewed Nov 5, 2025

View reviewed changes

sandy081 merged commit 04eca07 into main Nov 5, 2025
33 of 34 checks passed

sandy081 deleted the copilot/fix-6154722-41881900-301606d9-cd56-4cad-8673-5f2646fbb3ba branch November 5, 2025 11:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add configurable extension download timeout setting #274761

Add configurable extension download timeout setting #274761

Copilot AI commented Nov 3, 2025 •

edited

Loading

Uh oh!

sandy081 commented Nov 3, 2025

Uh oh!

Uh oh!

Copilot AI commented Nov 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 5, 2025

Uh oh!

chrisinmtown Nov 5, 2025

Uh oh!

Copilot AI Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	description: localize('extensionsRequestTimeout', "Controls the timeout in milliseconds for HTTP requests made when fetching extensions from the Marketplace"),
	description: localize('extensionsRequestTimeout', "Controls the timeout in milliseconds for HTTP requests made when fetching extensions from the Marketplace."),

Add configurable extension download timeout setting #274761

Add configurable extension download timeout setting #274761

Conversation

Copilot AI commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Usage

Comments on the Issue (you are @copilot in this section)

Uh oh!

sandy081 commented Nov 3, 2025

Uh oh!

Uh oh!

Copilot AI commented Nov 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

chrisinmtown Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Nov 3, 2025 •

edited

Loading