Add rust-toolchain.toml with Rust 1.90 #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
requested changes
Oct 9, 2025
rust-toolchain.toml
Outdated
| [toolchain] | ||
| channel = "1.90" | ||
| components = ["rustfmt", "clippy"] | ||
| targets = ["wasm32-wasip2", "wasm32-wasip1", "wasm32-unknown-unknown"] |
There was a problem hiding this comment.
wasm32-unknown-unknown is not needed @copilot
There was a problem hiding this comment.
Removed wasm32-unknown-unknown target in commit 9c87f47.
docs/cookbook/rust.md
Outdated
|
|
||
| ### Prerequisites | ||
| - Rust toolchain (1.75.0 or later) | ||
| - Rust toolchain (1.90.0 or later) |
There was a problem hiding this comment.
I don't think this needs to be changed
There was a problem hiding this comment.
Reverted the version change in commit 9c87f47.
docs/development/rust.md
Outdated
| Before you begin, ensure you have the following installed: | ||
|
|
||
| 1. **Rust toolchain** (1.75.0 or later): | ||
| 1. **Rust toolchain** (1.90.0 or later): |
There was a problem hiding this comment.
Reverted the version change in commit 9c87f47.
Copilot
AI
changed the title
Copilot finished work on behalf of
Mossaka
October 9, 2025 07:39
Copilot
AI
changed the title
Copilot finished work on behalf of
Mossaka
October 9, 2025 07:45
Co-authored-by: Mossaka <[email protected]>
Co-authored-by: Mossaka <[email protected]>
Mossaka
force-pushed
the
copilot/add-rust-toolchain-file
branch
from
23d99ce to
14a9bc3
Compare
Mossaka
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
rust-toolchain.tomlfile to specify Rust 1.90 as the stable toolchain version for the Wassette project, ensuring consistent Rust versions across all development environments and CI/CD pipelines.Problem
Previously, the project did not have a
rust-toolchain.tomlfile, which meant developers could potentially use different Rust versions, leading to inconsistent behavior and potential compatibility issues.Solution
Added
rust-toolchain.tomlwith the following configuration:rustfmtandclippyfor code formatting and lintingwasm32-wasip2andwasm32-wasip1for WebAssembly compilationThis ensures that:
Verification
All build, lint, and format checks pass successfully:
cargo build --workspace- compiles successfullycargo clippy --workspace- no warningscargo +nightly fmt --all -- --check- formatting is correctThe configuration aligns with the existing
flake.nixsetup, which uses similar targets for WebAssembly compilation.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.