Support official DSC v3 release #5313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
JohnMcPMS
changed the title
mdanish-kh
reviewed
Mar 21, 2025
azure-pipelines.yml
Outdated
| - powershell: | | ||
| Install-WinGetPackage -Id Microsoft.DSC.Preview -Source winget | ||
| $installResult = Install-WinGetPackage -Id Microsoft.DSC.Preview -Source winget -InstallerType Msix -Version 3.0.12 |
There was a problem hiding this comment.
Suggested change
| $installResult = Install-WinGetPackage -Id Microsoft.DSC.Preview -Source winget -InstallerType Msix -Version 3.0.12 | |
| $installResult = Install-WinGetPackage -Id Microsoft.DSC.Preview -Source winget -InstallerType Msix -Version 3.0.12.0 |
3.0.12 doesn't match the version on winget-pkgs, making the command fail
yao-msft
approved these changes
Mar 24, 2025
yao-msft
reviewed
Mar 24, 2025
| Install-WinGetPackage -Id Microsoft.DSC.Preview -Source winget | ||
| $installResult = Install-WinGetPackage -Id Microsoft.DSC.Preview -Source winget -InstallerType Msix -Version 3.1.1 | ||
| $installResult | Format-List | ||
| if ($installResult.ExtendedErrorCode) { throw $installResult.ExtendedErrorCode } |
There was a problem hiding this comment.
nit: do we still need these debug related scripts?
There was a problem hiding this comment.
That is what is installing DSC for the pipeline currently.
I'm still considering how best to have the configuration code paths handle acquiring DSC themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Install the specific, MSIX version from the winget-pkgs in the pipeline. (Store installs don't work on Server 2022)
In the processor, find
dsc.exeby the alias location. Support the preview version for test builds (anything from winget-cli).Validation
Running tests locally continues to work.
Microsoft Reviewers: Open in CodeFlow