Access Token Proof of Possession Capability #2512
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
7f46a1f to
21ed0a9
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
3 times, most recently
from
f46153c to
d79e836
Compare
adamedx
reviewed
Mar 5, 2024
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
d79e836 to
0a2936e
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
0a2936e to
5e9961e
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
5e9961e to
dd2f7e0
Compare
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
ffa1edb to
9f90a73
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
2 times, most recently
from
929b2b4 to
4d5e435
Compare
FehintolaObafemi
added
enhancement
bgavrilMS
reviewed
Jun 6, 2024
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication.Core/Interfaces/IGraphRequestProofofPossession.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication/Handlers/AuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 6, 2024
src/Authentication/Authentication/Handlers/AuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
| <PackageReference Include="Azure.Identity.Broker" Version="1.1.0" /> | ||
| <PackageReference Include="Microsoft.Graph.Core" Version="3.0.9" /> | ||
| <PackageReference Include="Azure.Identity" Version="1.12.0-beta.3" /> | ||
| <PackageReference Include="Azure.Identity.Broker" Version="1.2.0-beta.1" /> |
Contributor
There was a problem hiding this comment.
In previous conversations, we had wondered if Azure.Identity is actually bringing any value here over using Microsoft.Identity.Client directly. Azure.Identity is intended to limit the surface area exposed to 3P developers. This is not relevant for PowerShell scenarios. I am especially concerned when I see the introduction of Azure.Core.Pipeline. We explicitly don't use the Azure Pipelining because it is only there to abstract away language differences, and again that isn't relevant because our PowerShell modules are only implemented in C#.
src/Authentication/Authentication/Handlers/AuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
8883eda to
e708fc1
Compare
andrueastman
reviewed
Jul 4, 2024
src/Authentication/Authentication.Test/Microsoft.Graph.Authentication.Test.csproj
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
Outdated
Show resolved
Hide resolved
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
5 times, most recently
from
d2d03fa to
ff194cb
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
2 times, most recently
from
8b69aea to
a1f778a
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
34fb968 to
d811806
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
d811806 to
2136757
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
2136757 to
d599c48
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
d599c48 to
0b12cdb
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
0b12cdb to
08a14d8
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
2 times, most recently
from
31b2024 to
b63395f
Compare
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
b63395f to
7df1cc0
Compare
Adding AT PoP skeleton (#2511) * adding "-AT PoP" option to "Set-MgGraphOptions" --------- AT PoP Version 1 Fehintolaobafemi/methodanduri (#2751) * Making changes to how httpmethod and uri is processed --------- Fixing and updating the docs resolving build break fixing build issues related to docs resolving PR comments updating nuget packages removing unnecessary string assignment Resolving PR comments reverting test csproj changes
FehintolaObafemi
force-pushed
the
fehintolaobafemi/AT-PoP
branch
from
7df1cc0 to
0fe01a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request
Other links