Skip to content

Upgrade Go to 1.26.6 to fix CVE-2026-56858 [release-1.8] - #1471

Open
midays wants to merge 1 commit into
migtools:release-1.8from
midays:fix/cve-controller-html-template-release-1.8
Open

midays wants to merge 1 commit into
migtools:release-1.8from
midays:fix/cve-controller-html-template-release-1.8

Conversation

@midays

@midays midays commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Upgrades Go from 1.25.0 to 1.26.6 to fix html/template XSS vulnerability
  • Updates Dockerfile to use explicit golang:1.26.6-alpine instead of quay.io/konveyor/builder:latest

CVE Fixed

  • MIG-1987: CVE-2026-56858 - Go html/template: Cross-Site Scripting via pathological input
    • Affected: Go 1.26.0 to 1.26.5
    • Fixed in: Go 1.26.6+

Changes

  • Updated Dockerfile: FROM quay.io/konveyor/builder:latestFROM golang:1.26.6-alpine
  • Added build dependencies for CGO builds (gcc, musl-dev, git)
  • Updated go.mod: go 1.25.0go 1.26

Jira Ticket

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e80961b1-6a15-4cf8-9a66-a2bc223d84aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM quay.io/konveyor/builder:latest AS builder
FROM registry.redhat.io/openshift/golang-builder:golang-builder-v1.26-rhel8 AS builder

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the U/S pipeline can get this container without a pull secret.

@midays
midays force-pushed the fix/cve-controller-html-template-release-1.8 branch from 79af510 to 1f38819 Compare September 12, 2026 09:16
Changes:
- Updated Dockerfile to use OpenShift golang-builder v1.26
- Changed from: quay.io/konveyor/builder:latest
- Changed to: registry.redhat.io/openshift/golang-builder:golang-builder-v1.26-rhel8

This uses the official Red Hat UBI-based Go 1.26 builder image,
which contains Go 1.26.6 to fix the html/template CVE.

Fixes:
- MIG-1987: CVE-2026-56858 - Go html/template: Cross-Site Scripting via pathological input

Related:
- ocp-build-data PR: openshift-eng/ocp-build-data#12805

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@midays
midays force-pushed the fix/cve-controller-html-template-release-1.8 branch from 1f38819 to 0cd0093 Compare September 12, 2026 10:07
openshift-ci Bot pushed a commit to openshift-eng/ocp-build-data that referenced this pull request Sep 14, 2026
Upgrade rhel-8-golang builder image from v1.25 to v1.26 to support
mig-controller CVE fix (MIG-1987: CVE-2026-56858).

Related PRs:
- migtools/mig-controller#1470
- migtools/mig-controller#1471

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants