Skip to content

Design Doc, describe.go, and logs.go#13

Merged
NicholasYancey merged 10 commits into
mainfrom
nicholasyancey
Jul 8, 2025
Merged

Design Doc, describe.go, and logs.go#13
NicholasYancey merged 10 commits into
mainfrom
nicholasyancey

Conversation

@NicholasYancey

Copy link
Copy Markdown
Contributor

describe.go and logs.go currently do not operate as intended.

@NicholasYancey NicholasYancey self-assigned this Jul 3, 2025
@NicholasYancey NicholasYancey moved this to In Progress in oadp-cli v0.1 Jul 3, 2025
@Joeavaikath Joeavaikath moved this from In Progress to PR Status in oadp-cli v0.1 Jul 3, 2025
@NicholasYancey

Copy link
Copy Markdown
Contributor Author

logs.go should now get the backuprequest, get the url, then output the logs from that url

This was linked to issues Jul 3, 2025
Comment thread cmd/non-admin/backup/logs.go Outdated
Comment thread cmd/non-admin/backup/describe.go
@kaovilai kaovilai closed this Jul 7, 2025
@github-project-automation github-project-automation Bot moved this from Active PRs to Done in oadp-cli v0.1 Jul 7, 2025
@kaovilai kaovilai reopened this Jul 7, 2025

@kaovilai kaovilai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi you will need to resolve conflict with base branch.. if you need help reach out :)

@Joeavaikath Joeavaikath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
reply/resolve the comments and you should be good

@NicholasYancey NicholasYancey merged commit 8be9536 into main Jul 8, 2025
5 checks passed
@NicholasYancey NicholasYancey changed the title DNM Design Doc, describe.go, and logs.go Design Doc, describe.go, and logs.go Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Addition of Design Doc non-admin backup logs

3 participants