Skip to content

Use https protocol on hybrid apps instead of file protocol #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aldatsa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use https protocol on hybrid apps instead of file protocol #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions jquery.prettyembed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@
// Test for mobile devices
var mobile = (/Android|webOS|iPhone|iPad|iPod|BlackBerry/i.test(navigator.userAgent))? true : false;

// Get the URL protocol
var protocol = document.location.protocol;

var protocolPrefix = "";

// Used to fix problems with protocol relative URLs on hybrid apps (cordova...)
if (protocol === "file:") {
protocolPrefix = "https:";
}

// Inject styles if not already present
if ( $('#pretty-embed-style').length === 0 ) {
var styles = $('<style />', {
Expand Down Expand Up @@ -193,7 +203,7 @@
}

// Write the <img/> element
$(this).html('<img src="//img.youtube.com/vi/' + thisVideoID + '/' + previewSizePrefix + '.jpg" width="100%" alt="YouTube Video Preview" />');
$(this).html('<img src="' + protocolPrefix + '//img.youtube.com/vi/' + thisVideoID + '/' + previewSizePrefix + '.jpg" width="100%" alt="YouTube Video Preview" />');
}

if ( $(this).is('a') ) {
Expand Down Expand Up @@ -273,7 +283,7 @@
if ( (obj.attr('data-pe-allow-fullscreen') === 'false') || (options.allowFullScreen === false) ) { fullScreenFlag = ''; } else { fullScreenFlag = 'allowfullscreen '; }

// Write the YouTube video iFrame into the element at the exact dimensions it is now
obj.html('<iframe width="' + wrapperWidth + '" height="' + wrapperHeight + '" ' + fullScreenFlag + 'style="border:none;" src="//www.youtube.com/embed/' + thisVideoID + '?autoplay=1' + playerOptions + '"></iframe>')
obj.html('<iframe width="' + wrapperWidth + '" height="' + wrapperHeight + '" ' + fullScreenFlag + 'style="border:none;" src="' + protocolPrefix + '//www.youtube.com/embed/' + thisVideoID + '?autoplay=1' + playerOptions + '"></iframe>')
// Remove the YouTube 'play' button using a CSS class
.addClass('play');

Expand Down