Feature/commit template #1422
Closed
Feature/commit template #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add information about category.mode and commit_pr inputs. Add section for commit_pr template placeholders.
|
Thank you so much for the PR. Given the size it likely will take me a bit to review it in depth. |
|
merged here: #1427 |
|
Available in v5.2.0-b01: https://github.com/mikepenz/release-changelog-builder-action/releases/tag/v5.2.0-b01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm back with a new (and separate) PR for the commit template feature I developed a while ago. I hope it's still welcomed.
The feature can be described as follows:
Adds a new
commit_templateproperty to use for "fake" PRs inHYBRIDandCOMMITmodes.In this version, if no
commit_templateis provided it falls back to usingpr_template.I think in a future version it should become mandatory when using the action in
HYBRIDorCOMMITmodes.Adds an optional
modeproperty forcategorywhich makes it possible to define a category that only applies to either real PRs or fake PRs.By default it's in HYBRID mode which makes it apply to both types of PRs just like before.
I did my best to keep it backwards compatible, but there might be some issues with cached configurations. In the local tests, the way the configuration is loaded and prioritized works a bit differently than it does in "prod" from what I observed, so it's hard to say if it's 100% backwards compatible.