Skip to content

Add codecov.yml and configure codecov PR comments - #97

Open
lebrice wants to merge 5 commits into
mila-iqia:masterfrom
lebrice:codecov_pr_comments
Open

Add codecov.yml and configure codecov PR comments#97
lebrice wants to merge 5 commits into
mila-iqia:masterfrom
lebrice:codecov_pr_comments

Conversation

@lebrice

@lebrice lebrice commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@codecov-commenter

codecov-commenter commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.89%. Comparing base (f8bb9c1) to head (0eea9d3).
⚠️ Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
milatools/cli/commands.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   60.91%   60.89%   -0.02%     
==========================================
  Files           9        9              
  Lines        1379     1381       +2     
==========================================
+ Hits          840      841       +1     
- Misses        539      540       +1     
Flag Coverage Δ
integrationtests 11.36% <0.00%> (-0.02%) ⬇️
unittests 60.89% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Comment thread milatools/cli/commands.py
Comment on lines +386 to +389
def test_uncovered_code():
...


Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a comment mentioning that it isn't covered. We'll have to wait until the codecov app is approved by IT to get them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants