Fixed the interface which error does allow to compile with angular CL… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I 1.4.9 and Typescript 2.5.3
ChrisMBarr
reviewed
Apr 16, 2018
| }); | ||
| } | ||
| onHintsAdded(cb: Function) { | ||
| return this.intro.onhintclose(() => { |
There was a problem hiding this comment.
I've copied your code into my project, but notice this typo that's not your fault, but easily overlooked. This should use this.intro.onhintsadded here since the above method also calls this.intro.onhintclosed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the interface which error does allow to compile with angular CLI 1.4.9 and Typescript 2.5.3.
Could you update the npm package. Please?