Skip to content

enhance: optimize error log message for list policy #41251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

shaoting-huang
Copy link
Contributor

related: #41250

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 11, 2025
Copy link
Contributor

mergify bot commented Apr 11, 2025

@shaoting-huang

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@shaoting-huang shaoting-huang changed the title optimize error log message for list policy enhance: optimize error log message for list policy Apr 11, 2025
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.59%. Comparing base (9ce3e3c) to head (c2fcb55).
Report is 22 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41251      +/-   ##
==========================================
+ Coverage   80.36%   80.59%   +0.22%     
==========================================
  Files        1484     1475       -9     
  Lines      211989   209724    -2265     
==========================================
- Hits       170359   169017    -1342     
+ Misses      35472    34587     -885     
+ Partials     6158     6120      -38     
Components Coverage Δ
Client 79.59% <ø> (ø)
Core 72.32% <ø> (+2.00%) ⬆️
Go 82.01% <100.00%> (-0.16%) ⬇️
Files with missing lines Coverage Δ
internal/rootcoord/root_coord.go 86.73% <100.00%> (-1.88%) ⬇️

... and 109 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Apr 11, 2025
@weiliu1031
Copy link
Contributor

/lgtm

@tedxu
Copy link
Contributor

tedxu commented Apr 16, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e46e3a1 into milvus-io:master Apr 16, 2025
19 of 20 checks passed
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Apr 17, 2025
sre-ci-robot pushed a commit that referenced this pull request Apr 18, 2025
cherry-pick from master: #41251
related: #41250

Signed-off-by: shaoting-huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants