Docs: Feature item from RFC #48 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new YAML template for submitting feature requests derived from RFCs has been introduced. This structured template enhances clarity, encourages thoroughness, and standardizes communication within collaborative environments. Key fields prompt users to articulate problems, link relevant RFCs, propose solutions, and provide additional context, streamlining the evaluation and decision-making process. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
Triggered from #49 by @black7375. Checking if we can fast forward Target branch ( commit c62ffe7f4c4529be858e5d790f072a526933dcc0 (HEAD -> main, origin/main, origin/HEAD)
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Jul 22 01:32:15 2024 +0000
Chore(deps-dev): Bump the dev-dependencies group with 12 updates
Bumps the dev-dependencies group with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `20.14.10` | `20.14.11` |
| [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) | `2.0.2` | `2.0.3` |
| [terser](https://github.com/terser/terser) | `5.31.2` | `5.31.3` |
| [turbo](https://github.com/vercel/turbo) | `2.0.6` | `2.0.9` |
| [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `5.3.3` | `5.3.4` |
| [vite-node](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vite-node) | `2.0.2` | `2.0.3` |
| [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) | `2.0.2` | `2.0.3` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `7.16.0` | `7.16.1` |
| [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) | `5.1.3` | `5.2.1` |
| [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `7.16.0` | `7.16.1` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `7.16.0` | `7.16.1` |
| [eslint-plugin-react-refresh](https://github.com/ArnaudBarre/eslint-plugin-react-refresh) | `0.4.8` | `0.4.9` |
Updates `@types/node` from 20.14.10 to 20.14.11
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
Updates `@vitest/coverage-v8` from 2.0.2 to 2.0.3
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.0.3/packages/coverage-v8)
Updates `terser` from 5.31.2 to 5.31.3
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/compare/v5.31.2...v5.31.3)
Updates `turbo` from 2.0.6 to 2.0.9
- [Release notes](https://github.com/vercel/turbo/releases)
- [Changelog](https://github.com/vercel/turbo/blob/main/release.md)
- [Commits](https://github.com/vercel/turbo/compare/v2.0.6...v2.0.9)
Updates `vite` from 5.3.3 to 5.3.4
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.3.4/packages/vite)
Updates `vite-node` from 2.0.2 to 2.0.3
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.0.3/packages/vite-node)
Updates `vitest` from 2.0.2 to 2.0.3
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.0.3/packages/vitest)
Updates `@typescript-eslint/parser` from 7.16.0 to 7.16.1
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.16.1/packages/parser)
Updates `eslint-plugin-prettier` from 5.1.3 to 5.2.1
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-plugin-prettier/compare/v5.1.3...v5.2.1)
Updates `typescript-eslint` from 7.16.0 to 7.16.1
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.16.1/packages/typescript-eslint)
Updates `@typescript-eslint/eslint-plugin` from 7.16.0 to 7.16.1
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.16.1/packages/eslint-plugin)
Updates `eslint-plugin-react-refresh` from 0.4.8 to 0.4.9
- [Release notes](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/releases)
- [Changelog](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.4.8...v0.4.9)
---
updated-dependencies:
- dependency-name: "@types/node"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: "@vitest/coverage-v8"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: terser
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: turbo
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: vite
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: vite-node
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: vitest
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: "@typescript-eslint/parser"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: eslint-plugin-prettier
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: dev-dependencies
- dependency-name: typescript-eslint
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: eslint-plugin-react-refresh
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
...
Signed-off-by: dependabot[bot] <[email protected]>Pull request ( commit 67928c1260078e36d473f2d4a9a23585c7f3ff15 (pull_request/feature-request-rfc)
Author: alstjr7375 <[email protected]>
Date: Wed Jul 24 22:16:59 2024 +0900
Docs: Feature item from RFC #48It is possible to fast forward |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/ISSUE_TEMPLATE/feature_requests_from_rfc.yml (1 hunks)
Additional comments not posted (6)
.github/ISSUE_TEMPLATE/feature_requests_from_rfc.yml (6)
1-3: LGTM!The metadata fields (
name,description,labels) are correctly formatted.
5-14: LGTM!The
problemsection is well-defined, with appropriate attributes and validations.
15-23: LGTM!The
related-rfcsection is well-defined, with appropriate attributes and validations.
24-32: LGTM!The
solutionsection is well-defined, with appropriate attributes and optional validations.
33-41: LGTM!The
screenshotssection is well-defined, with appropriate attributes and optional validations.
42-58: LGTM!The
alternativesandadditional-contextsections are well-defined, with appropriate attributes and optional validations.
|
/fast-forward |
|
Triggered from #49 (comment) by @black7375. Trying to fast forward Target branch ( commit c62ffe7f4c4529be858e5d790f072a526933dcc0 (HEAD -> main, origin/main, origin/HEAD)
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon Jul 22 01:32:15 2024 +0000
Chore(deps-dev): Bump the dev-dependencies group with 12 updates
Bumps the dev-dependencies group with 12 updates:
| Package | From | To |
| --- | --- | --- |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `20.14.10` | `20.14.11` |
| [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) | `2.0.2` | `2.0.3` |
| [terser](https://github.com/terser/terser) | `5.31.2` | `5.31.3` |
| [turbo](https://github.com/vercel/turbo) | `2.0.6` | `2.0.9` |
| [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `5.3.3` | `5.3.4` |
| [vite-node](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vite-node) | `2.0.2` | `2.0.3` |
| [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) | `2.0.2` | `2.0.3` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `7.16.0` | `7.16.1` |
| [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) | `5.1.3` | `5.2.1` |
| [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `7.16.0` | `7.16.1` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `7.16.0` | `7.16.1` |
| [eslint-plugin-react-refresh](https://github.com/ArnaudBarre/eslint-plugin-react-refresh) | `0.4.8` | `0.4.9` |
Updates `@types/node` from 20.14.10 to 20.14.11
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
Updates `@vitest/coverage-v8` from 2.0.2 to 2.0.3
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.0.3/packages/coverage-v8)
Updates `terser` from 5.31.2 to 5.31.3
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/compare/v5.31.2...v5.31.3)
Updates `turbo` from 2.0.6 to 2.0.9
- [Release notes](https://github.com/vercel/turbo/releases)
- [Changelog](https://github.com/vercel/turbo/blob/main/release.md)
- [Commits](https://github.com/vercel/turbo/compare/v2.0.6...v2.0.9)
Updates `vite` from 5.3.3 to 5.3.4
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.3.4/packages/vite)
Updates `vite-node` from 2.0.2 to 2.0.3
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.0.3/packages/vite-node)
Updates `vitest` from 2.0.2 to 2.0.3
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.0.3/packages/vitest)
Updates `@typescript-eslint/parser` from 7.16.0 to 7.16.1
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.16.1/packages/parser)
Updates `eslint-plugin-prettier` from 5.1.3 to 5.2.1
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-plugin-prettier/compare/v5.1.3...v5.2.1)
Updates `typescript-eslint` from 7.16.0 to 7.16.1
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.16.1/packages/typescript-eslint)
Updates `@typescript-eslint/eslint-plugin` from 7.16.0 to 7.16.1
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.16.1/packages/eslint-plugin)
Updates `eslint-plugin-react-refresh` from 0.4.8 to 0.4.9
- [Release notes](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/releases)
- [Changelog](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.4.8...v0.4.9)
---
updated-dependencies:
- dependency-name: "@types/node"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: "@vitest/coverage-v8"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: terser
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: turbo
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: vite
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: vite-node
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: vitest
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: "@typescript-eslint/parser"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: eslint-plugin-prettier
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: dev-dependencies
- dependency-name: typescript-eslint
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
- dependency-name: eslint-plugin-react-refresh
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-dependencies
...
Signed-off-by: dependabot[bot] <[email protected]>Pull request ( commit 67928c1260078e36d473f2d4a9a23585c7f3ff15 (pull_request/feature-request-rfc)
Author: alstjr7375 <[email protected]>
Date: Wed Jul 24 22:16:59 2024 +0900
Docs: Feature item from RFC #48Fast forwarding $ git push origin 67928c1260078e36d473f2d4a9a23585c7f3ff15:main
To https://github.com/mincho-js/mincho.git
c62ffe7..67928c1 67928c1260078e36d473f2d4a9a23585c7f3ff15 -> main |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A template created to make it easy to create a feature issue from an RFC.
Related Issue
Summary by CodeRabbit
Additional context
Checklist