-
Notifications
You must be signed in to change notification settings - Fork 87
[OmniGen2] add fine-tuning script #1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hadipash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the capabilities of OmniGen2 by introducing robust fine-tuning functionalities. It provides the necessary infrastructure, including data loading, model configuration, and training pipelines, to adapt OmniGen2 models to specific tasks using both full-parameter and LoRA approaches. The changes also include crucial MindSpore compatibility fixes and enhancements for better training stability and observability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and valuable feature: fine-tuning capabilities for OmniGen2, covering both full-parameter and LoRA methods. The changes are extensive, including new training scripts, configuration examples, dataset handling logic, and updated documentation. The implementation is generally well-structured. However, I've identified a few critical issues in the new dataset sampling logic and callback implementations that must be addressed. There are also some medium-severity issues regarding documentation clarity and loss calculation for logging. After these fixes, this will be an excellent contribution to the project.
What does this PR do?
Fixes # (issue)
mindone/data/loader.py: Added a warning specifying thatmax_rowsizeis deprecated in MindSpore 2.6 or above.mindone/data/loader.py: Fixed a bug that caused column selection (dataloader.project(project_columns)) to be applied before batch transforms.TrainOneStepWrappernow delegates setting training mode (set_train()) to the model rather than setting the entire network to train mode.Adds # (feature)
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.