Skip to content

Conversation

@zyd-ustc
Copy link

What does this PR do?

Adds
1.Test code for Sam2

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

This file contains a testing suite for the MindSpore SAM model, including configurations and input preparation for various model components.
@zyd-ustc zyd-ustc requested a review from vigo999 as a code owner November 14, 2025 02:55
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zyd-ustc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates testing for the Sam2 model into the project's test suite. It establishes a robust testing framework for various components of Sam2, such as the prompt encoder and mask decoder, and includes cross-framework comparisons to validate the MindSpore implementation against its PyTorch counterpart. The primary goal is to ensure the functional correctness and numerical stability of the Sam2 model within the MindSpore ecosystem.

Highlights

  • New Test Files: Introduced new test files for the Sam2 model, specifically tests/transformers_tests/models/sam2/__init__.py and tests/transformers_tests/models/sam2/test_modeling_sam2.py.
  • Sam2 Model Testing: Added comprehensive test cases for the Sam2 model, including its Prompt Encoder, Mask Decoder, and the overall model, ensuring compatibility and correctness within the MindSpore framework.
  • Cross-Framework Comparison: Implemented tests that compare the outputs of MindSpore and PyTorch implementations of the Sam2 model, verifying numerical consistency across different data types (fp32, fp16, bf16) and execution modes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds test code for the Sam2 model. My review has identified several critical issues that would prevent the tests from running correctly. These include a TypeError during the test model's instantiation due to a missing argument, and a NameError from using an undefined function. Additionally, there are some latent bugs in helper classes that could cause AttributeErrors in the future. I have also included a suggestion to improve code style and readability. Addressing these points will ensure the tests are robust and maintainable.

zyd-ustc and others added 4 commits November 14, 2025 11:11
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant