-
Notifications
You must be signed in to change notification settings - Fork 89
Sam2 test #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sam2 test #1428
Conversation
This file contains a testing suite for the MindSpore SAM model, including configurations and input preparation for various model components.
Summary of ChangesHello @zyd-ustc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates testing for the Sam2 model into the project's test suite. It establishes a robust testing framework for various components of Sam2, such as the prompt encoder and mask decoder, and includes cross-framework comparisons to validate the MindSpore implementation against its PyTorch counterpart. The primary goal is to ensure the functional correctness and numerical stability of the Sam2 model within the MindSpore ecosystem. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds test code for the Sam2 model. My review has identified several critical issues that would prevent the tests from running correctly. These include a TypeError during the test model's instantiation due to a missing argument, and a NameError from using an undefined function. Additionally, there are some latent bugs in helper classes that could cause AttributeErrors in the future. I have also included a suggestion to improve code style and readability. Addressing these points will ensure the tests are robust and maintainable.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
What does this PR do?
Adds
1.Test code for Sam2
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx