-
Notifications
You must be signed in to change notification settings - Fork 89
feat(transformers): add VaultGemma (v4.57.1) #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @alien-0119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the VaultGemma model, which appears to be a port from the Hugging Face Transformers library. The implementation is comprehensive, including the model architecture and corresponding tests. My review focuses on ensuring code quality and correctness. I've identified a couple of areas for improvement: one is an incorrect type hint in the attention mechanism, and the other concerns the use of a wildcard import, which could be made more explicit for better code clarity. Overall, the changes are well-structured and the inclusion of tests is a great practice.
| past_key_values: Optional[Cache] = None, | ||
| cache_position: Optional[Tensor] = None, | ||
| **kwargs: Unpack[FlashAttentionKwargs], | ||
| ) -> tuple[Tensor, Optional[Tensor], Optional[tuple[Tensor]]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type hint of the construct method is incorrect. It's specified as tuple[Tensor, Optional[Tensor], Optional[tuple[Tensor]]] but the function returns a tuple of two elements: attn_output and attn_weights. The third element, presumably for past_key_values, is not returned. Since the cache is updated in-place, this is fine, but the type hint should be corrected to match the actual return signature for code clarity and to aid static analysis.
| ) -> tuple[Tensor, Optional[Tensor], Optional[tuple[Tensor]]]: | |
| ) -> tuple[Tensor, Optional[Tensor]]: |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| from .modeling_vaultgemma import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a wildcard import (*) is generally discouraged by PEP 8 as it can lead to namespace pollution and makes it difficult to track where names are coming from. While I see this pattern is used elsewhere in the repository, it's a good practice to explicitly import the public API. This improves code readability and helps static analysis tools.
| from .modeling_vaultgemma import * | |
| from .modeling_vaultgemma import ( | |
| VaultGemmaForCausalLM, | |
| VaultGemmaModel, | |
| VaultGemmaPreTrainedModel, | |
| ) | |
| __all__ = ["VaultGemmaForCausalLM", "VaultGemmaModel", "VaultGemmaPreTrainedModel"] |
d66122e to
f6ad07e
Compare
f6ad07e to
284e3f0
Compare
What does this PR do?
Adds # (feature)
Add VaultGemma model and fast ut.
Usage Example:
Performance:
Experiments were tested on Ascend Atlas 800T A2 machines with mindspore 2.7.0 pynative mode.
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx