-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/mintlayer app #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OBorce
wants to merge
308
commits into
master
Choose a base branch
from
feature/mintlayer-app
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
308 commits
Select commit
Hold shift + click to select a range
25f9fce
Merge pull request #21 from obsidiansystems/pending-support
yhql e799ad4
Revert "Temporarily point to our sdk"
Ericson2314 090156b
Update to latest (merged) SDK with pending support
Ericson2314 72022fa
Fix CI
Ericson2314 fecb94f
Merge branch 'pending-support' into fix-ci
Ericson2314 91940d9
Merge pull request #24 from obsidiansystems/fix-ci
yhql dd9ec66
Add missing api_level flag. Cleanup config
yhql a6ba592
[ci] Use cargo-ledger
yhql 873a144
Merge pull request #26 from LedgerHQ/cargoledger_update
yhql c0ea47b
Update README.md
yhql 72162e7
update to latest SDK
yhql edac388
fmt
yhql 7431fcf
Merge pull request #27 from LedgerHQ/update
yhql f8b14e2
use dedicated sections for each device
yogh333 c1e2849
Merge pull request #28 from yogh333/feat/update_manifest
yhql 43e50eb
[clean] Moving to new manifest format
Leereen f3d9f26
Merge pull request #32 from LedgerHQ/update/manifest
lpascal-ledger 3444069
Add new main menu based on MultiPageMenu gadget.
agrojean-ledger 14aa875
Use MultiFieldReview gadget for tx review.
agrojean-ledger 6da298a
Update authors, version and crate name in Cargo.toml
agrojean-ledger 9cfd8a2
Update .gitignore
agrojean-ledger 5d2ca17
Update app instruction handling and UI.
agrojean-ledger e423064
Add Ragger tests and remove obsolete functional tests.
agrojean-ledger 00d537f
Add transaction signing APDU handling and display.
agrojean-ledger 0cab934
Stack usage optim : use slices, not arrays in Tx struct.
agrojean-ledger 11b9590
Add test snapshots for LNX / LNSP
agrojean-ledger 6e48413
Remove unnecessary fields from config.toml
agrojean-ledger b134372
Remove local version of nanos_ui in Cargo.toml
agrojean-ledger b57d5bd
Format
agrojean-ledger a132cd4
Use dependencies from the new SDK workspace.
agrojean-ledger 337f1b9
Introduce new App Status Words enum and use it instead of io::Reply a…
agrojean-ledger 3c16549
Update CI
agrojean-ledger 0aafd40
Merge pull request #31 from LedgerHQ/update-app
agrojean-ledger 955db01
Update dependencies to latest SDK versions for update .elf metadatas
agrojean-ledger 7821659
Update CI with reusable workflows
agrojean-ledger b98ef03
Update app manifest to add pytest directory field.
agrojean-ledger 83f1e4e
Ignore word "crate" in misspelling checks.
agrojean-ledger 1d35ecc
Rename python tests checks workflow for clarity.
agrojean-ledger 69ef4c2
Add "name" field in Cargo.toml [package.metadata.ledger] category
agrojean-ledger 6972549
Fix static analysis
agrojean-ledger 23ec722
Update pending review function
agrojean-ledger ef5d187
Add "clear pending review" fixture in python tests.
agrojean-ledger 031d292
Use v1 of reusable workflows in CI as the work branch for rust suppor…
agrojean-ledger 683338a
Merge pull request #35 from LedgerHQ/update-ci
agrojean-ledger 6bef1f8
Use json + serde for Tx deserialization.
agrojean-ledger 8d5c4aa
Small improvements in APDU handling
agrojean-ledger 5d13761
Code cleanup
agrojean-ledger ca88f2d
Destination address now stored as u8 array
kingofpayne 7f7ea72
Use hex crate for hexadecimal formatting
kingofpayne c335be5
Amount now as coin string and u64
kingofpayne 4548218
Fixed error management in ui_display_tx
kingofpayne d17979b
Minor code improvement
kingofpayne 5ff6f1d
Destination address to uppercase
kingofpayne 78e4b1c
Fix static analysis
agrojean-ledger 72a9dbe
Fix python tests lint and type checking
agrojean-ledger 0c2c24e
Update tests snapshots
agrojean-ledger 3182781
Merge pull request #34 from LedgerHQ/use-serde
agrojean-ledger 252f8b7
Improved APDU parsing logic
kingofpayne d5e98d4
Removed unnecessary data length checks
kingofpayne 902564b
[auto]: add PR template
sgliner-ledger 0228594
Feat/use ledger device sdk only (#37)
yogh333 22b80ca
Code simplification
kingofpayne a24aaba
Fixed imports due to SDK changes
kingofpayne 69d383d
Minor refactoring on CLA checking
kingofpayne 1a7cb7b
Cargo fmt
kingofpayne 94d8be1
Merge branch 'main' into better-commands-parsing
kingofpayne f062ea5
Removed unused import
kingofpayne c0957e7
Fixed compilation error
kingofpayne 8f48d21
Minor fixes following code review
kingofpayne 156f2a7
Removed status word duplicate
kingofpayne 90d176f
Merge pull request #39 from LedgerHQ/better-commands-parsing
kingofpayne 45489e0
main.rs: Use display_pending_review() from SDK
ade9a0f
Merge pull request #41 from LedgerHQ/xch/display_pending_review
xchapron-ledger a6ab4bb
Update README
agrojean-ledger 1cef80c
Merge pull request #40 from LedgerHQ/update-readme
agrojean-ledger cd4c36f
Fix README typos.
agrojean-ledger bccc6c9
Merge pull request #42 from LedgerHQ/fix-readme-typos
agrojean-ledger 2a9020a
Use Comm::set_expected_cla from the new SDK (#44)
kingofpayne 083b1d7
Bug fix and improvements in BIP32 path parsing (#45)
kingofpayne ee0fbed
remove testing messages (#48)
yhql 36b4c56
Test/multifield review refactor (#50)
agrojean-ledger 5427b1c
Add pending_review_screen as an app's feature only
yogh333 3f8f9d1
Bump version and update tests accordingly
yogh333 fc2380c
Merge pull request #51 from LedgerHQ/jca/pending_review_feature
yogh333 3803127
Bump SDK version
yogh333 45b68d5
Merge pull request #52 from LedgerHQ/jca/bump_sdk_version
yogh333 b83d26c
[auto] Update screenshot
sgliner-ledger 5514b7d
Use last Rust SDK, not needed anymore to use sys crate and unsafe calls
yogh333 9f37efc
Merge pull request #53 from LedgerHQ/jca/update_sdk_version
yogh333 5899511
Update Readme: Ragger tests can be launched without duplicating build…
yogh333 add43b7
Update nightly version to match Docker builds
brianp af61974
swap command arguments to correct order
brianp 223e5e5
Update rust SDK and fix keccak256 declaration
bboilot-ledger 015f922
Update nanox and nanos golden snapshots
bboilot-ledger 064b0aa
Merge pull request #57 from LedgerHQ/bboilot/update_sdk
bboilot-ledger 7873f48
Move rustup default next to rustup install
bboilot-ledger 8a0fdd7
Merge pull request #56 from brianp/readme-fixes
bboilot-ledger 1611150
Merge pull request #54 from LedgerHQ/yogh333/update_readme
yogh333 83e42d3
Add Stax support
agrojean-ledger 870a751
Small updates for NBGL sync integration.
agrojean-ledger 7e319a9
Use new include_gif macro to generate NBGL glyphs.
agrojean-ledger a977014
Update code + test snapshots following C string conversion support in…
agrojean-ledger e74326d
Add Flex support.
agrojean-ledger e4f0c88
Add settings example.
agrojean-ledger dfafdff
Add dashboard icons for Stax and Flex.
agrojean-ledger 10281b3
Update tests snapshots following version bump in Cargo.toml
agrojean-ledger 98648b3
Use init_comm from nbgl rust module to initialize Comm object reference
agrojean-ledger 240f7a0
Update test_version test to parse version directly from Cargo.toml
agrojean-ledger 5a00f1a
Update get pub key tests snapshots to show status screens.
agrojean-ledger 6d6be89
Update cargo.lock
agrojean-ledger cc5c0c8
Fix TOML parsing library import.
agrojean-ledger afd5bb8
Fix static analysis.
agrojean-ledger 779deec
Fix icon files bit depth and update tests snapshots.
agrojean-ledger b09dcc1
Update README
agrojean-ledger 02b1c32
PR review.
agrojean-ledger 46a0075
Update usage.md
agrojean-ledger 2aa6e97
Merge pull request #49 from LedgerHQ/test-stax-build
agrojean-ledger 4887fa2
Update SDK version for lock-screen fix on Stax / Flex.
agrojean-ledger 57d01bd
Merge pull request #59 from LedgerHQ/update-sdk
agrojean-ledger 9ec3374
Use of heap feature for simpler code
kingofpayne 52f7992
Ragger tests OK for Nano S+,X, Stax and Flex
yogh333 0e52ff5
Use last Rust SDK + Bump version
yogh333 06c6b64
Remove Nano S support
yogh333 6589826
Restore crab.gif
yogh333 755ef1b
Merge pull request #58 from LedgerHQ/feat/heap
agrojean-ledger 2fb9a41
Update Flex snapshots
fbeutin-ledger 90333d0
Merge pull request #62 from LedgerHQ/fbe/update_flex_snapshots
fbeutin-ledger b9d237d
Update snapshots
yogh333 09fe2d2
Bump version
yogh333 a3291e9
Update snapshots after version bump
yogh333 69babaa
Merge pull request #63 from LedgerHQ/y333/heap_is_default
yogh333 78c9d3a
Update rust SDK version + update tests snapshots.
agrojean-ledger d3f4951
Fix Cargo.lock
agrojean-ledger 868afd8
Fix ragger version.
agrojean-ledger 9644f2b
Merge pull request #65 from LedgerHQ/update-sdk
agrojean-ledger 7e2fe3f
Update rust SDK + include_gif macro versions.
agrojean-ledger 02fbf26
Update Cargo.lock
agrojean-ledger 2ac6b40
Merge pull request #66 from LedgerHQ/update-sdk
agrojean-ledger 39b4d58
Implement status screens for Stax/Flex now that they are not managed …
agrojean-ledger d9c3deb
Merge pull request #67 from LedgerHQ/update-status-display-for-nbgl-d…
agrojean-ledger 8b921a6
Bump SDK version and update snapshots
yogh333 5ce6a28
Merge pull request #72 from LedgerHQ/y333/update_sdk_version
yogh333 343d6da
Add an option for opening PRs with golden run result in CI
fbeutin-ledger cb25636
Merge pull request #73 from LedgerHQ/fbe/golden_run_CI
fbeutin-ledger 6adc1b1
[auto-update] Update Ragger snapshots
github-actions[bot] 8d5e93c
Merge pull request #74 from LedgerHQ/auto/update_snapshots-6adc1b1
fbeutin-ledger f4f483b
[auto-update] Update Ragger snapshots
github-actions[bot] bddcf06
Merge pull request #75 from LedgerHQ/auto/update_snapshots-f4f483b
yogh333 1163156
Use sync NbglHomeAndSettings and stop redraw screen for each received…
yogh333 1d8aed0
Fix clippy issues
yogh333 99b1f53
Update function's name which show status + home screen
yogh333 f112621
Use single loop
yogh333 b44d113
Fix clippy issue
yogh333 a293755
Use last SDK and bump version
yogh333 f3297d5
Update snapshots
yogh333 52811eb
Remove useless binding
yogh333 2fe39d2
Merge pull request #76 from LedgerHQ/y333/use_sync_nbgl_homeandsettings
yogh333 121d4c6
Update SDK and bump version
yogh333 5718519
Update snapshots
yogh333 021e51a
Refactor settings management
yogh333 727b84d
Call get_mut when retrieving settings
yogh333 8eac496
Update dependencies
yogh333 3d4893f
Update BP
yogh333 1181357
Use last SDK + update snapshots
yogh333 ef33289
Merge pull request #77 from LedgerHQ/y333/settings_management
yogh333 481c957
Create dependabot.yml
yogh333 0a88cb4
Merge pull request #78 from LedgerHQ/yogh333-patch-1
yogh333 c101f9d
Bump ledger_device_sdk from 1.17.2 to 1.17.3
dependabot[bot] 97abb23
Merge pull request #81 from LedgerHQ/dependabot/cargo/ledger_device_s…
yogh333 fa73f86
Heap size can be set at application level
yogh333 3d9999f
Add explnations
yogh333 7c21b52
Bump Rust SDK versions
yogh333 4b1bd9b
Merge pull request #82 from LedgerHQ/y333_20241001/heap_size_mngt
yogh333 86ee160
Bump SDK version
yogh333 2b0b17d
Merge pull request #84 from LedgerHQ/y333_241021/bump_sdk_version
yogh333 af6a45b
Bump ledger_device_sdk from 1.17.5 to 1.18.1
dependabot[bot] 9aaeb51
Update README
yogh333 c36949e
Merge pull request #86 from LedgerHQ/dependabot/cargo/ledger_device_s…
yogh333 9c32cff
Remove --user when running docker
yogh333 0a80b69
Merge pull request #87 from LedgerHQ/y333_241025/update_readme
yogh333 98b5f82
Update build_and_functional_tests.yml comment
tdejoigny-ledger 4688eb9
Merge pull request #89 from LedgerHQ/tdj/update_comment
tdejoigny-ledger 1e74333
Bump ledger_device_sdk from 1.18.1 to 1.18.3
dependabot[bot] c07bb11
Merge pull request #93 from LedgerHQ/dependabot/cargo/ledger_device_s…
yogh333 43bfe5f
Bump ledger_device_sdk from 1.18.3 to 1.18.4
dependabot[bot] b14b3a9
Merge pull request #94 from LedgerHQ/dependabot/cargo/ledger_device_s…
tdejoigny-ledger f1d916f
Disallow references to static mut
yogh333 72a7673
Update Cargo.lock
yogh333 56b6297
Update Cargo config files
yogh333 642807a
Fix Clippy issue
yogh333 7e9fc2a
Bump SDK version
yogh333 4a60095
Updated snapshots
yogh333 180974a
Merge pull request #99 from LedgerHQ/y333_17122024/migration_to_updat…
yogh333 471e913
Bump ledger_device_sdk from 1.19.1 to 1.19.4
dependabot[bot] c1e8a9b
Merge pull request #102 from LedgerHQ/dependabot/cargo/ledger_device_…
yogh333 3dccf4b
Update readme
yogh333 8cf6d74
update and fix typo
yogh333 cbb12f2
Merge pull request #103 from LedgerHQ/y333/update_readme
yogh333 f317d2b
Use default-features to fix cargo warning
ghallak 78401ec
Bump ledger_device_sdk from 1.19.4 to 1.20.2
dependabot[bot] 8c5a3bb
Merge pull request #110 from LedgerHQ/dependabot/cargo/ledger_device_…
yogh333 bc17baa
Merge pull request #106 from ghallak/cargo-warn
yogh333 93acfb5
Bump SDK version
yogh333 97f0ae4
Merge pull request #112 from LedgerHQ/y333/bump_sdk_version
yogh333 a682870
Build Nano* version with NBGL
yogh333 e5db3c4
Bump version
yogh333 1bba463
Updated snapshots for Stax/Flex
yogh333 70b5663
Merge pull request #114 from LedgerHQ/y333/nanos_nbgl_migration
yogh333 a48a594
Use new feature name in Rust SDK
yogh333 12d743d
Use last Rust SDK
yogh333 e12d5c4
Merge pull request #119 from LedgerHQ/y333/use_nbgl_nanos_feature
yogh333 65ad8b7
Bump ledger_device_sdk from 1.21.4 to 1.22.3
dependabot[bot] 052f8fb
Fix Cargo.toml path for pytest
cedelavergne-ledger 4d9d7ad
Merge pull request #126 from LedgerHQ/cev/fix_test_version
cedelavergne-ledger 75a4df5
Merge pull request #125 from LedgerHQ/dependabot/cargo/ledger_device_…
tdejoigny-ledger ac90f9d
[auto-update] Update Ragger snapshots
github-actions[bot] 96fbe55
Merge pull request #133 from LedgerHQ/auto/update_snapshots-ac90f9d
cedelavergne-ledger bab19a6
[auto-update] Update Ragger snapshots
github-actions[bot] 3abfb52
Merge pull request #135 from LedgerHQ/auto/update_snapshots-bab19a6
cedelavergne-ledger 8f0efbd
Force usage of a targeted nightly
yogh333 7848163
Bump versions
yogh333 c1e2729
Update snapshots after version bump
yogh333 043aa7f
Use ledgered Device rather thar Ragger Firmware object
yogh333 99f3788
Bump SDK + update snapshots
yogh333 8715674
Merge pull request #136 from LedgerHQ/y333/improve_build_settings_mngt
yogh333 4c18304
mintalyer
OBorce ecc2602
Initial mintlayer implementation
OBorce 0a568f1
Add support for multisig addresses
OBorce 62009d1
add negative tests
OBorce dde9cb0
add sign transaction type subtitle
OBorce be664ba
add negative tests
OBorce 936fab0
update tests
OBorce eb07397
add streaming review
OBorce 741995c
Add address type for sign message
OBorce 3bfa55f
Merge with master
OBorce 7c1d9f4
update test snapshots
OBorce b506eef
update ledger sdk
OBorce 2fa1c33
fix comments
OBorce 78bd2e2
fix missed comments
OBorce d65b520
Remove Get app name and version instructions
OBorce 3d38d90
fix streaming review starting too early
OBorce d09c9c5
fix comments
OBorce 5b02b46
change messages
OBorce f0a534a
Move additional input info into along input messages
OBorce da0e723
fix tests
OBorce 2a03f21
flatten tx inputs for better memory efficiency
OBorce 5faeaaf
Use new TxInfoWithAdditionalInfo
OBorce b87b78a
fix tests
OBorce ad084ac
fix comments
OBorce bf565b1
bump deps and toolchain
OBorce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| [target.apex_p] | ||
| runner = "speculos -m apex_p" | ||
|
|
||
| [build] | ||
| target = "apex_p" | ||
|
|
||
| [profile.release] | ||
| opt-level = 'z' | ||
| lto = true | ||
| codegen-units = 1 | ||
|
|
||
| [unstable] | ||
| build-std = ["core", "alloc"] | ||
| build-std-features = ["compiler-builtins-mem"] | ||
|
|
||
| # By default, heap size is enforced to 8192 bytes. | ||
| # Authorized values are [2048, 4096, 8192, 16384, 24576] | ||
| # We use 16k as we get some crashes on 8k when running the tests with big 20+ input TXs | ||
| [env] | ||
| HEAP_SIZE = "16384" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Auto detect text files and perform LF normalization | ||
| * text=auto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # To get started with Dependabot version updates, you'll need to specify which | ||
| # package ecosystems to update and where the package manifests are located. | ||
| # Please see the documentation for all configuration options: | ||
| # https://docs.github.com/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file | ||
|
|
||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "cargo" # See documentation for possible values | ||
| directory: "/" # Location of package manifests | ||
| schedule: | ||
| interval: "daily" | ||
| allow: | ||
| - dependency-name: "ledger_device_sdk" | ||
| - dependency-name: "include_gif" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: Build and run functional tests using ragger through reusable workflow | ||
|
|
||
| # This workflow will build the app and then run functional tests using the Ragger framework upon Speculos emulation. | ||
| # It calls a reusable workflow developed by Ledger's internal developer team to build the application and upload the | ||
| # resulting binaries. | ||
| # It then calls another reusable workflow to run the Ragger tests on the compiled application binary. | ||
| # | ||
| # The build part of this workflow is mandatory, this ensures that the app will be deployable in the Ledger App Store. | ||
| # While the test part of this workflow is optional, having functional testing on your application is mandatory and this workflow and | ||
| # tooling environment is meant to be easy to use and adapt after forking your application | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| golden_run: | ||
| type: choice | ||
| required: true | ||
| default: 'Raise an error (default)' | ||
| description: CI behavior if the test snaphots are different than expected. | ||
| options: | ||
| - 'Raise an error (default)' | ||
| - 'Open a PR' | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
| - develop | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| build_application: | ||
| name: Build application using the reusable workflow | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1 | ||
| with: | ||
| upload_app_binaries_artifact: "compiled_app_binaries" | ||
| builder: ledger-app-builder | ||
|
|
||
| ragger_tests: | ||
| name: Run ragger tests using the reusable workflow | ||
| needs: build_application | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1 | ||
| with: | ||
| download_app_binaries_artifact: "compiled_app_binaries" | ||
| regenerate_snapshots: ${{ inputs.golden_run == 'Open a PR' }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Run coding style check | ||
|
|
||
| # This workflow will run linting checks to ensure a level of code quality among all Ledger applications. | ||
| # | ||
| # The presence of this workflow is mandatory as a minimal level of linting is required. | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
| - develop | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| check_linting: | ||
| name: Check linting using the reusable workflow | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_lint.yml@v1 | ||
| with: | ||
| source: './src' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Ensure compliance with Ledger guidelines | ||
|
|
||
| # This workflow is mandatory in all applications | ||
| # It calls a reusable workflow guidelines_enforcer developed by Ledger's internal developer team. | ||
| # The successful completion of the reusable workflow is a mandatory step for an app to be available on the Ledger | ||
| # application store. | ||
| # | ||
| # More information on the guidelines can be found in the repository: | ||
| # LedgerHQ/ledger-app-workflows/ | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
| - develop | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| guidelines_enforcer: | ||
| name: Call Ledger guidelines_enforcer | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_guidelines_enforcer.yml@v1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Misspellings checks | ||
|
|
||
| # This workflow performs some misspelling checks on the repository | ||
| # It is there to help us maintain a level of quality in our codebase and does not have to be kept on forked | ||
| # applications. | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
| - develop | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| misspell: | ||
| name: Check misspellings | ||
| uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_spell_check.yml@v1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: Checks on the Python tests | ||
|
|
||
| # This workflow performs some checks on the Python client used by the Boilerplate tests | ||
| # It is there to help us maintain a level of quality in our codebase and does not have to be kept on forked | ||
| # applications. | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
| - develop | ||
| pull_request: | ||
|
|
||
| jobs: | ||
|
|
||
| lint: | ||
| name: Boilerplate client linting | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Clone | ||
| uses: actions/checkout@v3 | ||
| - name: Installing PIP dependencies | ||
| run: | | ||
| pip install pylint | ||
| pip install --extra-index-url https://test.pypi.org/simple/ -r tests/requirements.txt | ||
| - name: Lint Python code | ||
| run: | | ||
| pylint --rc tests/setup.cfg tests/application_client/ | ||
|
|
||
| mypy: | ||
| name: Type checking | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Clone | ||
| uses: actions/checkout@v3 | ||
| - name: Installing PIP dependencies | ||
| run: | | ||
| pip install mypy | ||
| pip install --extra-index-url https://test.pypi.org/simple/ -r tests/requirements.txt | ||
| - name: Mypy type checking | ||
| run: | | ||
| mypy tests/application_client/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| target | ||
| app.json | ||
| app_nanos.json | ||
| app_nanosplus.json | ||
| app_nanox.json | ||
| app_stax.json | ||
| app_flex.json | ||
|
|
||
OBorce marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # Temporary directory with snapshots taken during test runs | ||
| tests/snapshots-tmp/ | ||
|
|
||
| .DS_Store | ||
|
|
||
| # Python | ||
| *.pyc[cod] | ||
| *.egg | ||
| __pycache__/ | ||
| *.egg-info/ | ||
| .eggs/ | ||
| .python-version | ||
|
|
||
| # Related to the Ledger VSCode extension | ||
| # Virtual env for sideload (macOS and Windows) | ||
| ledger/ | ||
| # Build directory | ||
| build/ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the file to
build_and_run_functional_tests.yml?