Adding loader for Vienna 4x22 Piano Corpus - #707
Conversation
Adds a mirdata loader for the Vienna 4x22 Piano Corpus (88 piano performances, 4 pieces × 22 pianists) backed by partitura for score/MIDI/alignment parsing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yujin-kimmm
left a comment
There was a problem hiding this comment.
Hi @anusfoil , thanks for this PR!
This dataset looks good and I left some comments. Please let me know if you have questions.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 97.22% 97.20% -0.02%
==========================================
Files 71 72 +1
Lines 7845 7905 +60
==========================================
+ Hits 7627 7684 +57
- Misses 218 221 +3 🚀 New features to boost your workflow:
|
…string - Update index URL to v2 Zenodo record (21399563) where the correct vienna4x22_index_1.0.json is now uploaded - Add midi: ✅ row and update annotations description in table.rst - Remove forward-reference to parangonar from alignment_quality docstring Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for the review @yujin-kimmm ! I've addressed all comments:
|
|
@anusfoil Thank you! I have one last question. I just found the audio files of this dataset from the link in the repo, and I was wondering if the reason why audio is not in this loader is because the audio files and the symbolic data is not related each other? or from different institution? |
- Add load_audio() returning stereo (np.ndarray, sr) via librosa - Add audio_path attribute and audio cached property to Track - Add 'audio' remote pointing to mdw.ac.at audio.zip (1.2 GB, CC BY 4.0) - Update make_vienna4x22_index.py with --audio_path flag and AUDIO_FOLDERS map - Add audio entries (path + md5) to full index and sample index - Add test_load_audio and audio assertions in test_track - Update table.rst: audio ❌ → 🔑 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Thanks for the reminder Yujin! I was in symbolic for too long that I totally forgot this one has audio.... it's perfectly corresponded haha, I have just amend the PR to add it. |
Summary
mirdata[vienna4x22]) for parsing MusicXML scores, performance MIDIs, and.matchscore-to-performance alignment filesChecklist
mirdata/datasets/vienna4x22.py) withTrack,load_score,load_performance,load_matchvienna4x22_index_1.0.json) on Zenodo; sample index for teststests/datasets/test_vienna4x22.py) — all passingscripts/make_vienna4x22_index.py)pyproject.tomloptional depvienna4x22 = ["partitura>=1.7.0"]environment-ci.yml) updated with partituraautodoc_mock_imports,mirdata.rst,table.rst🤖 Generated with Claude Code