Open
Conversation
Owner
|
Hard to believe we'd have to resort to such things, but it seems you're right. I'd be ok merging it, but can we make it a configuration option? |
BugsBeGone
referenced
this pull request
in brentinrochester/android2po
Mar 6, 2025
Use double-quotes around the xml header strings. Indent lines with four spaces.
Contributor
|
@rv0 No idea if this is still of any interest to you, but I found this fork commit (brentinrochester@48d9f09) that does the job in a much cleaner way, now that lxml supports |
|
Thanks @BugsBeGone for making that connection. I honestly thought I had put in a pull request for this a while back. I wouldn't have remembered if not for the tag. #76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a little proof of concept I did today:
android2po does 2 space indentation in xml files and there's no way to configure it otherwise.
this is a limitation of the lxml library used.
android studio's default is 4 spaces, which can get tricky when working with a lot of people on a single project and trying to keep git history clean
the only way to add more spaces sadly is by processing the text line by line. But it works as demonstrated in this PR.
I would not merge this pull request just yet, but I'm hoping other people might find this code useful or suggestions are made to make this more configurable.