ci: drop unneeded publish env from non-secret-using lint jobs#222
Merged
Nelson-PROIA merged 2 commits intoMay 21, 2026
Merged
Conversation
The test_custom_code workflow runs lint, build, and unit tests, and does not reference any secrets. Pinning it to the publish environment forces the env approval flow on every PR and limits it to the branches allowed by the publish environment's branch policy, which causes unnecessary failures for feature branches that are not whitelisted.
Same fix as the test workflow: the lint job in run_example_scripts only builds, no secrets. The examples job below it keeps env: publish since it actually uses MISTRAL_API_KEY.
Nelson-PROIA
changed the title
andreaonofrei01
self-requested a review
May 20, 2026 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two workflows have a non-secret-using job pinned to
environment: publish:test_custom_code.yaml(lint + build + unit tests)run_example_scripts.yaml'slintjob (build only)Neither references any secret, so the env declaration adds no security but does cause friction:
publishenvironment's branch policy (currently onlymain)This PR removes those env declarations. The
examplesjob inrun_example_scripts.yamlkeepsenvironment: publishsince it actually usesMISTRAL_API_KEY.