fix(package.json): align OpenTelemetry peer dependency ordering with generated output#244
Merged
Merged
Conversation
…pendencies The peerDependencies and peerDependenciesMeta keys were committed at the end of package.json, but the code generator emits peerDependencies after scripts and peerDependenciesMeta after license. That position mismatch caused a package.json merge conflict on regeneration. Reorder to match the generated output; no dependency values change.
Nelson-PROIA
force-pushed
the
fix/package-json-otel-dependency-ordering
branch
from
759cce2 to
13403d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reorder the OpenTelemetry peer-dependency keys in
package.jsonto match the position the code generator emits:peerDependenciesMeta→ afterlicensepeerDependencies→ afterscriptsWhy
These keys are generator-managed but were committed in a non-canonical position (both blocks at the end of the file). On regeneration the generator re-emits them in their canonical position, which collided with the committed ordering and produced a
package.jsonmerge conflict during generation.Reordering to match the generated output resolves the conflict. No dependency values change — only key positions.