Open
Conversation
…y scaling/max depth arguments to when generating point cloud
mbpeterson70
reviewed
Apr 6, 2026
Collaborator
There was a problem hiding this comment.
@aneesas Should we use effective_scale here to be consistent between the two depth --> point cloud conversions?
Contributor
Author
There was a problem hiding this comment.
Whoops--yes, good catch!
mbpeterson70
approved these changes
Apr 6, 2026
Collaborator
mbpeterson70
left a comment
mbpeterson70
left a comment
There was a problem hiding this comment.
@aneesas Looks good, thanks for the fix! I think it makes sense to address my one comment above, then looks good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open3D ignores scaling and max depth arguments for 32-bit images when creating a point cloud from a depth image. This change handles that case.