Update #232

[HalosGhost]

This supersedes #232; really all it does is add my DCO sign-off to each commit from #232, update the relevant documentation and workflows, and rename the scripts to be as clear as possible.

[HalosGhost]

@maurermi and @madars, mind taking a brief look at this? I can't quite tell if this last CI check failing here is because the docker workflow is building against the currently-published images (which don't have the new search-path defined in CMakeLists.txt, of course), or something setup incorrectly. With the small tweaks I've made, everything builds fine locally (including forcing a build of the docker images locally) so I suspect my intuition is correct, but I'd love a second set of eyes on it.

[maurermi]

@HalosGhost I think what's happening is that now the CMake build is not searching the prefix/ directory for libraries and associated header files -- making an attempt to fix this now

[HalosGhost]

But to be clear, that's only happening for the docker pull/build CI step (e.g., the full build step works fine using the updated files).

[maurermi]

Yeah, the build-docker.sh script is different in that it goes based off of the Dockerfile, which does not set the -DCMAKE_PREFIX_PATH flag AFAIK. Using the build-docker.sh script I have been able to recreate the error given by the CI

[HalosGhost]

oh, that's true for me as well; to fix, I just commented out the line in Dockerfile which specifies the upstream URL (forcing a local build), which succeeds. If fixing that would fix the environment would fix the CI though, I'm all for it.

[maurermi]

T-ACK, with the change to the Dockerfile to include "prefix" within CMAKE_PREFIX_PATH, then this looks to me to work properly. Added some other minor comments, but the only thing that really needs addressing is the Dockerfile IMO

[maurermi]

LGTM -- think this is ready to merge if there is consensus

[HalosGhost]

LGTM -- think this is ready to merge if there is consensus

I'm still getting build errors locally, but I think I may know what's causing them. If I'm right (and it's an oddity with my local setup), then I'll merge ASAP.

[HalosGhost]

Indeed the errors above seem to be due to some oddity of my setup; running in act locally has no issues at all (nor does the GH CI, obviously). @maurermi great catch on the environment update. Merging!