fix: update docker base image to ubuntu 22.04 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having migrated to C++20, we ran into a version of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100346 By migrating to a more recent Ubuntu image, we benefit from more recent compiler versions which avoid the build errors. The additional library linkages for the benchmarks seem to have become required on some platforms in addition. Signed-off-by: Sam Stuewe <[email protected]>
rockett-m
reviewed
Mar 8, 2024
rockett-m
reviewed
Mar 9, 2024
rockett-m
reviewed
Mar 9, 2024
maurermi
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
T-ACK. These changes fix the previously (recently) observed error in building using Docker. Tested by running scripts/build-docker.sh and running the test suite in Docker. Looks good to merge.
One note is that scripts/Dockerfile seems like it is not necessary to keep around. I am not sure what it does and had no issue building the docker containers without it.
|
cf. #252 (comment) for my reasoning for leaving this in in this PR; once we've finished vetting that it won't break any other tooling we have (most obviously the TC), I'd be happy to accept a PR to remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having migrated to C++20, we ran into a version of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100346
By migrating to a more recent Ubuntu image, we benefit from more recent compiler versions which avoid the build errors.
The additional library linkages for the benchmarks seem to have become required on some platforms in addition.